Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit id columns from metric calculations #106

Open
katxiao opened this issue Nov 24, 2021 · 2 comments
Open

Omit id columns from metric calculations #106

katxiao opened this issue Nov 24, 2021 · 2 comments
Labels
feature request Request for a new feature

Comments

@katxiao
Copy link
Contributor

katxiao commented Nov 24, 2021

Problem Description

Columns of type id should be dropped when computing metrics. ID columns are not synthetically generated, so should not contribute to the metric calculation. Currently they are being classified as categorical, which is incorrect.

Expected behavior

DetectionMetric should use the provided metadata to drop id columns from the real and synthetic data when computing the metric. This logic should also be applied to any other relevant metrics.

@katxiao katxiao added new feature pending review This issue needs to be further reviewed, so work cannot be started and removed pending review This issue needs to be further reviewed, so work cannot be started labels Nov 24, 2021
@npatki
Copy link
Contributor

npatki commented Dec 14, 2021

Some metrics are are already implemented with the correct behavior. Eg any MultiSingleColumn metric (such as KSTest) has a declared set of field_types that it is compatible with. Only those fields are selected when computing the metric.

@npatki
Copy link
Contributor

npatki commented Jul 14, 2022

Seems like the detection metric hasn't used the metadata at all. We're using #119 to track this.

But we should keep this issue open as a general one for ID columns across any metric.

@npatki npatki added feature request Request for a new feature and removed new feature labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants