Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing phrasing #5

Open
sulco opened this issue Feb 23, 2023 · 2 comments
Open

Confusing phrasing #5

sulco opened this issue Feb 23, 2023 · 2 comments

Comments

@sulco
Copy link

sulco commented Feb 23, 2023

Love the explainer!

One thing that confused me is the opening step with the juxtaposition of the definition of signals having no arguments and the example that shows a signal with an argument:

image

Not sure how to present it better tbh, but wanted to point out that this might throw other readers off too
@ayoayco
Copy link

ayoayco commented Mar 2, 2023 •
edited

@sulco I had the same thoughts and I submitted a PR for this. #4

@sdras
Copy link
Owner

sdras commented Mar 19, 2023

Makes sense, I'll put in an update that clarifies soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sulco @sdras @ayoayco