Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce specificity of selectors #319

Open
kentcdodds opened this issue Mar 29, 2023 · 1 comment
Open

Reduce specificity of selectors #319

kentcdodds opened this issue Mar 29, 2023 · 1 comment

Comments

@kentcdodds
Copy link

Please make sure you're using the latest version of the plugin before submitting an issue

Screenshots

227631785-8b0f2c70-a168-44e6-bc15-defcc3803930

When working in an .mdx file with the latest mdx highlighter, I'm no longer getting highlights for several things which the maintainer of the mdx language highlighter is telling me is due to Night Owl being overly specific in its selectors:

And that’s where we find a very important bug in Night Owl:

Looking at almost all scopes in Night Owl, they are super specific. Specific to JS, or to JSX, or to markdown. And they’re not supposed to be like that, they’re supposed to as vague as possible (markdup.heading), unless you really need to differentiate markup.heading.markdown from others (e.g. markup.heading.html) or so.

So that’s where a lot of the problems come from!

Inline code

  • GitHub : markup.raw
  • VS Code Solarized: markup.inline.raw
  • VS Code Night Owl: markup.inline.raw.markdown

I think this is a weird choice in VS Code themes to go with markup.inline.raw. markup.raw.inline makes more sense, then you can also have markup.raw.block. But I’ve just pushed the name VS Code uses: 60fa64b. Note that Night Owl still should drop the .markdown suffix.

That last comment is the suggestion:

Night Owl still should drop the .markdown suffix.

Could we do that?

@andreluis-oliveira
Copy link

@kentcdodds PR to fix support to mdx files.

Before:
before

After:
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants