Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring for Object properties defined by shorthand #275

Open
abhijit-hota opened this issue Oct 15, 2020 · 3 comments
Open

Coloring for Object properties defined by shorthand #275

abhijit-hota opened this issue Oct 15, 2020 · 3 comments
Labels

Comments

@abhijit-hota
Copy link

Please make sure you're using the latest version of the plugin before submitting an issue
Version: 2.0.0

Object properties that are defined using the shorthand (line 26 in the screenshot), should also have the purple color that is given for properties defined as usual.

Screenshots
image

Not sure if this is intended or a bug but I think making all the keys of same color would be better.

P.S. Thanks for the awesome theme! =)

@abhijit-hota abhijit-hota changed the title Coloring for Object property:value shorthand Coloring for Object properties defined by shorthand Oct 15, 2020
@sdras sdras added the 2.0 label Oct 18, 2020
@sdras
Copy link
Owner

sdras commented Oct 18, 2020

Thank you! I have to use it and think about it a minute, because someone else wanted this to be distinct. Appreciate the feedback!

@ivansvlv
Copy link
Contributor

ivansvlv commented Nov 3, 2020

IMO, having this distinction in syntax highlighting emphasises shorthand, since colour of the shorthand matches the colour of the identifier that is used, it improves legibility.

Just my 2 cents.

@abhijit-hota
Copy link
Author

colour of the shorthand matches the colour of the identifier that is used

But aren't all identifiers colored white after initialization? I might be wrong here.

Although, they're fair points and looking at it, a distinction between the shorthand is good when it resembles the type of variable (but that doesn't seem to the case?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants