Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 isn't coloring/dinstinctint template literals from strings #274

Open
JavierPiedra opened this issue Oct 15, 2020 · 6 comments
Open

2.0 isn't coloring/dinstinctint template literals from strings #274

JavierPiedra opened this issue Oct 15, 2020 · 6 comments
Labels

Comments

@JavierPiedra
Copy link

JavierPiedra commented Oct 15, 2020

image

@sdras
Copy link
Owner

sdras commented Oct 18, 2020

well, hm... someone else asked that they be the same color. I have to think of what to do now. I think I agree with you, let me use the new version a bit and see.

@sdras sdras added the 2.0 label Oct 18, 2020
@ivansvlv
Copy link
Contributor

ivansvlv commented Nov 3, 2020

Do you think it's necessary or useful to colour them differently? Template literal produces a string so it's quite intuitive to consider it as a string. Besides, template literals usual usage is to interpolate values into the string, and I would argue that Night Owl has one of the best interpolation highlighting, thus making it pretty obvious what are you working with.

@JavierPiedra
Copy link
Author

Do you think it's necessary or useful to colour them differently? Template literal produces a string so it's quite intuitive to consider it as a string. Besides, template literals usual usage is to interpolate values into the string, and I would argue that Night Owl has one of the best interpolation highlighting, thus making it pretty obvious what are you working with.

Yes, it has been useful to me, specially to find it quickly. I notice the change.

@selensr
Copy link

selensr commented Nov 25, 2020

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.

Screen Shot 2020-11-25 at 10 19 42

@ivansvlv
Copy link
Contributor

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.

Screen Shot 2020-11-25 at 10 19 42

Do you have this extension installed? - https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel

If yes, it might be causing your component colouring change.

@selensr
Copy link

selensr commented Nov 25, 2020

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.
Screen Shot 2020-11-25 at 10 19 42

Do you have this extension installed? - https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel

If yes, it might be causing your component colouring change.

Yes, it is indeed. Thank you a lot. Tags and texts back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants