default port and host for reporters

Author: sdb

app/com/github/sdb/play2/metrics/Reporter.scala

@@ -53,7 +53,7 @@ private object Reporter extends ReporterConfigurationSupport {
   }
 
   lazy val graphite: (String, Configuration) => Reporter = (name, config) =>
-    Graphite(name, config, config.period, config.unit, config.host, config.port, config.getString("prefix"))
+    Graphite(name, config, config.period, config.unit, config.host("localhost"), config.port(2003), config.getString("prefix"))
 
 
   case class Ganglia(name: String, configuration: Configuration, period: Long, unit: TimeUnit, host: String, port: Int) extends DynamicReporter {
@@ -66,5 +66,5 @@ private object Reporter extends ReporterConfigurationSupport {
   }
 
   lazy val ganglia: (String, Configuration) => Reporter = (name, config) =>
-    Ganglia(name, config, config.period, config.unit, config.host, config.port)
+    Ganglia(name, config, config.period, config.unit, config.host("localhost"), config.port(8649))
 }

app/com/github/sdb/play2/metrics/ReporterConfigurationSupport.scala

@@ -10,8 +10,8 @@ private trait ReporterConfigurationSupport {
     def period = conf.getInt("period") getOrElse 1
     def enabled = conf.getBoolean("enabled") getOrElse false
     def unit = conf.getString("unit", Some(Set((TimeUnit.values.toSeq map(_.toString)):_*))) map(TimeUnit.valueOf(_)) getOrElse TimeUnit.MINUTES
-    def host = conf.getString("host") getOrElse "localhost"
-    def port = conf.getInt("port") getOrElse 2003
+    def host(default: => String) = conf.getString("host") getOrElse default
+    def port(default: => Int) = conf.getInt("port") getOrElse default
     def path(name: String) = new File(conf.getString(name) getOrElse ".")
   }
 

build.sbt

@@ -8,7 +8,8 @@ resolvers += "Typesafe repository" at "http://repo.typesafe.com/typesafe/release
 
 libraryDependencies ++= Seq(
   "play" %% "play" % "2.1.0" % "provided",
-  "com.yammer.metrics" % "metrics-core" % "2.2.0" % "provided"
+  "com.yammer.metrics" % "metrics-core" % "2.2.0" % "provided",
+  "org.specs2" %% "specs2" % "1.14" % "test"
 )
 
 scalaSource in Compile <<= baseDirectory { (base) => base / "app" }
@@ -17,6 +18,8 @@ resourceDirectory in Compile <<= baseDirectory { (base) => base / "conf" }
 
 scalaSource in Test <<= baseDirectory { (base) => base / "test" }
 
+javacOptions ++= Seq("-source", "1.6", "-target", "1.6")
+
 licenses := Seq("Apache License, Version 2.0" -> url("http://www.apache.org/licenses/LICENSE-2.0.html"))
 
 homepage := Some(url("http://sdb.github.com/play2-metrics/"))

test/com/github/sdb/play2/metrics/ReporterConfigurationSpec.scala

@@ -0,0 +1,21 @@
+package com.github.sdb.play2
+package metrics
+
+import org.specs2.Specification
+import org.specs2.matcher.DataTables
+import play.api.Configuration
+
+object ReporterConfigurationSpec extends Specification with DataTables { def is =
+  "read period from config"  ! pending^
+  "read enabled from config"  ! pending^
+  "read unit from config"  ! pending^
+  "read host from config"  ! pending^
+  "read port from config"  ! pending^
+  "read file path from config"  ! pending
+
+
+//  val data = a.map(a => Map("period" -> a)) getOrElse Map.empty
+//  val conf = Configuration.from(data)
+//  val reporterConfig = new ReporterConfigurationSupport.ReporterConfiguration(conf)
+//  reporterConfig.period must_== b
+}