{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":28449431,"defaultBranch":"master","name":"scylladb","ownerLogin":"scylladb","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-12-24T13:16:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/14364730?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716795199.0","currentOid":""},"activityList":{"items":[{"before":"47dbf2377301ce1496671a347ff377fd8b76cd6d","after":"f70e888ed54513f3d9d0b629e0ef493105dc8d69","ref":"refs/heads/next","pushedAt":"2024-05-27T08:23:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"build: cmake: pass -fprofile-list to compiler\n\nto mirror the behavior of the build.ninja generated by configure.py\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18734","shortMessageHtmlLink":"build: cmake: pass -fprofile-list to compiler"}},{"before":"e0f4d79f3bb4f643ff524cde49067a670061d996","after":"47dbf2377301ce1496671a347ff377fd8b76cd6d","ref":"refs/heads/next","pushedAt":"2024-05-27T07:51:19.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"Merge 'Rework view services and system-distributed-keyspace dependencies' from Pavel Emelyanov\n\nThe system-distributed-keyspace and view-update-generator often go in pair, because streaming, repair and sstables-loader (via distributed-loader) need them booth to check if sstable is staging and register it if it's such. The check is performed by messing directly with system_distributed.view_build_status table, and the registration happens via view-update-generator.\n\nThat's not nice, other services shouldn't know that view status is kept in system table. Also view-update-generator is a service to generae and push view updates, the fact that it keeps staging sstables list is the implementation detail.\n\nThis PR replaces dependencies on the mentioned pair of services with the single dependency on view-builder (repair, sstables-loader and stream-manager are enlightened) and hides the view building-vs-staging details inside the view_builder.\n\nAlong the way, some simplification of repair_writer_impl class is done.\n\nCloses scylladb/scylladb#18706\n\n* github.com:scylladb/scylladb:\n  stream_manager: Remove system_distributed_keyspace and view_update_generator\n  repair: Remove system_distributed_keyspace and view_update_generator\n  streaming: Remove system_distributed_keyspace and view_update_generator\n  sstables_loader: Remove system_distributed_keyspace and view_update_generator\n  distributed_loader: Remove system_distributed_keyspace and view_update_generator\n  view: Make register_staging_sstable() a method of view_builder\n  view: Make check_view_build_ongoing() helper a method of view_builder\n  streaming: Proparage view_builder& down to make_streaming_consumer()\n  repair: Keep view_builder& on repair_writer_impl\n  distributed_loader: Propagate view_builder& via process_upload_dir()\n  stream_manager: Add view builder dependency\n  repair_service: Add view builder dependency\n  sstables_loader: Add view_bulder dependency\n  main: Start sstables loader later\n  repair: Remove unwanted local references from repair_meta","shortMessageHtmlLink":"Merge 'Rework view services and system-distributed-keyspace dependenc…"}},{"before":"46d993a283ba401419bf7242fb8937c4cd64e47a","after":"e0f4d79f3bb4f643ff524cde49067a670061d996","ref":"refs/heads/next","pushedAt":"2024-05-27T07:48:46.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"Merge 'Do not export statement scheduling group from database' from Pavel Emelyanov\n\nDatabase used to be (and still is in many ways) an object used to get configuration from. Part of the configuration is the set of pre-configured scheduling groups. That's not nice, services should use each other for some real need, not as proxies to configuration. This patch patches the places that explicitly switch to statement group _not_ to use database to get the group itself.\n\nfixes: #17643\n\nCloses scylladb/scylladb#18799\n\n* github.com:scylladb/scylladb:\n  database: Don't export statement scheduling group\n  test: Use async attrs and cql-test-env scheduling groups\n  test: Use get_scheduling_groups() to get scheduling groups\n  api: Don't switch sched group to start/stop protocol servers\n  main: Don't switch sched group to start protocol servers\n  code: Switch to sched group in request_stop_server()\n  code: Switch to server sched group in start()\n  protocol_server: Keep scheduling group on board\n  code: Add scheduling group to controllers\n  redis: Coroutinize start() method","shortMessageHtmlLink":"Merge 'Do not export statement scheduling group from database' from P…"}},{"before":"00f00f4e2e41072b2f2b60181d45b19addc213cf","after":null,"ref":"refs/heads/mergify/copy/branch-5.4/pr-18489","pushedAt":"2024-05-27T07:33:19.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"3ba2f6812f221d1194577778ab0ad85ff479eeee","after":null,"ref":"refs/heads/mergify/copy/branch-5.2/pr-18489","pushedAt":"2024-05-27T07:32:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":null,"after":"d078bafa007d2b7fe1e08a5d48387c10541b494f","ref":"refs/heads/mergify/copy/branch-6.0/pr-18489","pushedAt":"2024-05-27T07:32:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Update ScyllaDB version to: 6.0.0-rc1","shortMessageHtmlLink":"Update ScyllaDB version to: 6.0.0-rc1"}},{"before":"2ab143fb40ec90f467cd07b93cb76683f83790a5","after":"46d993a283ba401419bf7242fb8937c4cd64e47a","ref":"refs/heads/next","pushedAt":"2024-05-27T07:15:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nyh","name":"Nadav Har'El","path":"/nyh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/584227?s=80&v=4"},"commit":{"message":"test: revert 4c1b6f04\n\nin 4c1b6f04, we added a concept for fmt::is_formattable<>. but it\nwas not ncessary. the fmt::is_formattable<> trait was enough. the\nreason 4c1b6f04 was actually a leftover of a bigger change which\ntried to add trait for the cases where fmt::is_formattable<> was\nnot able to cover. but that was based on the wrong impression that\nfmt::is_formattable<> should be able to work with container types\nwithout including, for instance `fmt/ranges.h`. but in 222dbf2c,\nwe include `fmt/ranges.h` in tests, where the range-alike formatter\nis used, that enables `fmt::is_formattable<>` to tell that container\ntypes are formattable.\n\nin short, 4c1b6f04 was created based on a misunderstanding, and\nit was a reduced type trait, which is proved to be not necessary.\n\nso, in this change, it is dropped. but the type constraints is\npreserved to make the build failure more explicit, if the fallback\nformatter does not match with the type to be formatted by Boost.test.\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18879","shortMessageHtmlLink":"test: revert <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/scylladb/scylladb/commit/4c1b6f04764d786ce90bd21c737e37d4396aeadd/hovercard\" href=\"https://github.com/scylladb/scylladb/commit/4c1b6f04764d786ce90bd21c737e37d4396aeadd\"><tt>4c1b6f0</tt></a>"}},{"before":"caf5c69594d6561aabd1e06a0995a6fba0e3f74a","after":null,"ref":"refs/heads/mergify/copy/branch-5.4/pr-18634","pushedAt":"2024-05-27T06:14:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"32be38dae556936b56061a3860c1da077602f9b4","after":"331e0c4ca7965f69fa420d8a24464175b50add6c","ref":"refs/heads/next-5.2","pushedAt":"2024-05-27T05:52:16.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"Merge '[Backport 5.2] mutation_fragment_stream_validating_filter: respect validating_level::none' from ScyllaDB\n\nEven when configured to not do any validation at all, the validator still did some. This small series fixes this, and adds a test to check that validation levels in general are respected, and the validator doesn't validate more than it is asked to.\n\nFixes: #18662\n\n(cherry picked from commit f6511ca1b02e171b2d3e85865e39d52d0f335cf7)\n\n(cherry picked from commit e7b07692b6ba48af7bee655d4b28e7a4f897a4b6)\n\n(cherry picked from commit 78afb3644cb9f610bde59fd2cbafe71c9e616fbc)\n\n Refs #18667\n\nCloses #18723\n\n* github.com:scylladb/scylladb:\n  test/boost/mutation_fragment_test.cc: add test for validator validation levels\n  mutation: mutation_fragment_stream_validating_filter: fix validation_level::none\n  mutation: mutation_fragment_stream_validating_filter: add raises_error ctor parameter","shortMessageHtmlLink":"Merge '[Backport 5.2] mutation_fragment_stream_validating_filter: res…"}},{"before":"321bbd093ccc675d1b241a9d9ed292d08bc36a1d","after":"c11c5643ba0552d63c60b65bb62ab2d5b97d46ba","ref":"refs/heads/gh-pages","pushedAt":"2024-05-27T02:56:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Publish docs","shortMessageHtmlLink":"Publish docs"}},{"before":null,"after":"94058b442501455125003fd621ce49cf3eb37d7a","ref":"refs/heads/mergify/copy/branch-6.0/pr-18769","pushedAt":"2024-05-27T02:53:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"db: auth: move auth tables to system keyspace\n\nSeparate keyspace which also behaves as system brings\nlittle benefit while creating some compatibility problems\nlike schema digest mismatch during rollback. So we decided\nto move auth tables into system keyspace.\n\nFixes https://github.com/scylladb/scylladb/issues/18098\n\n(cherry picked from commit 4925f003662e368b92b18a1de68f65c4b50082c0)","shortMessageHtmlLink":"db: auth: move auth tables to system keyspace"}},{"before":"125464f2d9bbfa587a914bcdf9b72c7727fe86c8","after":"2ab143fb40ec90f467cd07b93cb76683f83790a5","ref":"refs/heads/master","pushedAt":"2024-05-27T02:51:22.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"db: auth: move auth tables to system keyspace\n\nSeparate keyspace which also behaves as system brings\nlittle benefit while creating some compatibility problems\nlike schema digest mismatch during rollback. So we decided\nto move auth tables into system keyspace.\n\nFixes https://github.com/scylladb/scylladb/issues/18098\n\nCloses scylladb/scylladb#18769","shortMessageHtmlLink":"db: auth: move auth tables to system keyspace"}},{"before":"56d523b071f314f10a2b1332aded5c689f3d78f1","after":"2ab143fb40ec90f467cd07b93cb76683f83790a5","ref":"refs/heads/next","pushedAt":"2024-05-26T19:31:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"db: auth: move auth tables to system keyspace\n\nSeparate keyspace which also behaves as system brings\nlittle benefit while creating some compatibility problems\nlike schema digest mismatch during rollback. So we decided\nto move auth tables into system keyspace.\n\nFixes https://github.com/scylladb/scylladb/issues/18098\n\nCloses scylladb/scylladb#18769","shortMessageHtmlLink":"db: auth: move auth tables to system keyspace"}},{"before":"6f0d32a42f231713f48dac005e0b37babfdb7556","after":"32be38dae556936b56061a3860c1da077602f9b4","ref":"refs/heads/branch-5.2","pushedAt":"2024-05-26T17:22:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"make timestamp string format cassandra compatible\n\nwhen we convert timestamp into string it must look like: '2017-12-27T11:57:42.500Z'\nit concerns any conversion except JSON timestamp format\nJSON string has space as time separator and must look like: '2017-12-27 11:57:42.500Z'\nboth formats always contain milliseconds and timezone specification\n\nFixes #14518\nFixes #7997\n\nCloses #14726\nFixes #16575\n\n(cherry picked from commit ff721ec3e32610ac0a65113f20e20efd8c784eed)\n\nCloses #18852","shortMessageHtmlLink":"make timestamp string format cassandra compatible"}},{"before":"4e9596a5a9f078ce581ddc8194c87c9a1a10cfca","after":"56d523b071f314f10a2b1332aded5c689f3d78f1","ref":"refs/heads/next","pushedAt":"2024-05-26T16:19:38.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"Merge 'build, test: disable operator<< for vector and unordered_map' from Kefu Chai\n\nthis series disables operator<<:s for vector and unordered_map, and drop operator<< for mutation, because we don't have to keep it to work with these operator:s anymore. this change is a follow up of https://github.com/scylladb/seastar/issues/1544\n\nthis change is a cleanup. so no need to backport\n\nCloses scylladb/scylladb#18866\n\n* github.com:scylladb/scylladb:\n  mutation,db: drop operator<< for mutation and seed_provider_type&\n  build: disable operator<< for vector and unordered_map\n  db/heat_load_balance: include used header\n  test: define a more generic boost_test_print_type\n  test/boost: define fmt::formatter for service_level_controller_test.cc\n  test/boost: include test/lib/test_utils.hh","shortMessageHtmlLink":"Merge 'build, test: disable operator&lt;&lt; for vector and unordered_map' …"}},{"before":"9108952a5200d9e21346dbdec3fd190ba46c834c","after":"4e9596a5a9f078ce581ddc8194c87c9a1a10cfca","ref":"refs/heads/next","pushedAt":"2024-05-26T13:45:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nyh","name":"Nadav Har'El","path":"/nyh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/584227?s=80&v=4"},"commit":{"message":"treewide: replace std::result_of_t with std::invoke_result_t\n\nin theory, std::result_of_t should have been removed in C++20. and\nstd::invoke_result_t is available since C++17. thanks to libstdc++,\nthe tree is compiling. but we should not rely on this.\n\nso, in this change, we replace all `std::result_of_t` with\n`std::invoke_result_t`. actually, clang + libstdc++ is already warning\nus like:\n\n```\nIn file included from /home/runner/work/scylladb/scylladb/multishard_mutation_query.cc:9:\nIn file included from /home/runner/work/scylladb/scylladb/schema/schema_registry.hh:11:\nIn file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/unordered_map:38:\nWarning: /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/type_traits:2624:5: warning: 'result_of<void (noop_compacted_fragments_consumer::*(noop_compacted_fragments_consumer &))()>' is deprecated: use 'std::invoke_result' instead [-Wdeprecated-declarations]\n 2624 |     using result_of_t = typename result_of<_Tp>::type;\n      |     ^\n/home/runner/work/scylladb/scylladb/mutation/mutation_compactor.hh:518:43: note: in instantiation of template type alias 'result_of_t' requested here\n  518 |         if constexpr (std::is_same_v<std::result_of_t<decltype(&GCConsumer::consume_end_of_stream)(GCConsumer&)>, void>) {\n      |\n```\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18835","shortMessageHtmlLink":"treewide: replace std::result_of_t with std::invoke_result_t"}},{"before":"6f0d32a42f231713f48dac005e0b37babfdb7556","after":"32be38dae556936b56061a3860c1da077602f9b4","ref":"refs/heads/next-5.2","pushedAt":"2024-05-26T13:31:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nyh","name":"Nadav Har'El","path":"/nyh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/584227?s=80&v=4"},"commit":{"message":"make timestamp string format cassandra compatible\n\nwhen we convert timestamp into string it must look like: '2017-12-27T11:57:42.500Z'\nit concerns any conversion except JSON timestamp format\nJSON string has space as time separator and must look like: '2017-12-27 11:57:42.500Z'\nboth formats always contain milliseconds and timezone specification\n\nFixes #14518\nFixes #7997\n\nCloses #14726\nFixes #16575\n\n(cherry picked from commit ff721ec3e32610ac0a65113f20e20efd8c784eed)\n\nCloses #18852","shortMessageHtmlLink":"make timestamp string format cassandra compatible"}},{"before":"125464f2d9bbfa587a914bcdf9b72c7727fe86c8","after":"9108952a5200d9e21346dbdec3fd190ba46c834c","ref":"refs/heads/next","pushedAt":"2024-05-26T12:32:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nyh","name":"Nadav Har'El","path":"/nyh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/584227?s=80&v=4"},"commit":{"message":"test/cql-pytest: Add test for token() filter againts mutation_fragments()\n\nWhen selecting from mutation_fragments(table) one may want to apply\ntoken() filtering againts partition key. This doesn't work currently,\nbut used to crash. This patch adds a regression test for that\n\nrefs: #18637\nrefs: #18768\n\nSigned-off-by: Pavel Emelyanov <xemul@scylladb.com>\n\nCloses scylladb/scylladb#18759","shortMessageHtmlLink":"test/cql-pytest: Add test for token() filter againts mutation_fragmen…"}},{"before":null,"after":"21ab0a689d1183cea19eea81eca9d41fde424a8c","ref":"refs/heads/mergify/copy/branch-6.0/pr-18838","pushedAt":"2024-05-26T12:12:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"migration_manager: do not reference moved-away smart pointer\n\nthis change is inspired by clang-tidy. it warns like:\n```\n[752/852] Building CXX object service/CMakeFiles/service.dir/migration_manager.cc.o\nWarning: /home/runner/work/scylladb/scylladb/service/migration_manager.cc:891:71: warning: 'view' used after it was moved [bugprone-use-after-move]\n  891 |             db.get_notifier().before_create_column_family(*keyspace, *view, mutations, ts);\n      |                                                                       ^\n/home/runner/work/scylladb/scylladb/service/migration_manager.cc:886:86: note: move occurred here\n  886 |             auto mutations = db::schema_tables::make_create_view_mutations(keyspace, std::move(view), ts);\n      |                                                                                      ^\n```\nin which,  `view` is an instance of view_ptr which is a type with the\nsemantics of shared pointer, it's backed by a member variable of\n`seastar::lw_shared_ptr<const schema>`, whose move-ctor actually resets\nthe original instance. so we are actually accessing the moved-away\npointer in\n\n```c++\ndb.get_notifier().before_create_column_family(*keyspace, *view, mutations, ts)\n```\n\nso, in this change, instead of moving away from `view`, we create\na copy, and pass the copy to\n`db::schema_tables::make_create_view_mutations()`. this should be fine,\nas the behavior of `db::schema_tables::make_create_view_mutations()`\ndoes not rely on if the `view` passed to it is a moved away from it or not.\n\nthe change which introduced this use-after-move was 88a5ddabce\n\nRefs 88a5ddabcec625434b2df0ed82a63c36245af35f\nFixes #18837\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n(cherry picked from commit 988cfcb5652d5be9bf069f9631d409c5607cb626)","shortMessageHtmlLink":"migration_manager: do not reference moved-away smart pointer"}},{"before":"de798775fd30bd07b0cc31d0465364d3e2816e9b","after":"125464f2d9bbfa587a914bcdf9b72c7727fe86c8","ref":"refs/heads/master","pushedAt":"2024-05-26T12:11:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"migration_manager: do not reference moved-away smart pointer\n\nthis change is inspired by clang-tidy. it warns like:\n```\n[752/852] Building CXX object service/CMakeFiles/service.dir/migration_manager.cc.o\nWarning: /home/runner/work/scylladb/scylladb/service/migration_manager.cc:891:71: warning: 'view' used after it was moved [bugprone-use-after-move]\n  891 |             db.get_notifier().before_create_column_family(*keyspace, *view, mutations, ts);\n      |                                                                       ^\n/home/runner/work/scylladb/scylladb/service/migration_manager.cc:886:86: note: move occurred here\n  886 |             auto mutations = db::schema_tables::make_create_view_mutations(keyspace, std::move(view), ts);\n      |                                                                                      ^\n```\nin which,  `view` is an instance of view_ptr which is a type with the\nsemantics of shared pointer, it's backed by a member variable of\n`seastar::lw_shared_ptr<const schema>`, whose move-ctor actually resets\nthe original instance. so we are actually accessing the moved-away\npointer in\n\n```c++\ndb.get_notifier().before_create_column_family(*keyspace, *view, mutations, ts)\n```\n\nso, in this change, instead of moving away from `view`, we create\na copy, and pass the copy to\n`db::schema_tables::make_create_view_mutations()`. this should be fine,\nas the behavior of `db::schema_tables::make_create_view_mutations()`\ndoes not rely on if the `view` passed to it is a moved away from it or not.\n\nthe change which introduced this use-after-move was 88a5ddabce\n\nRefs 88a5ddabcec625434b2df0ed82a63c36245af35f\nFixes #18837\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18838","shortMessageHtmlLink":"migration_manager: do not reference moved-away smart pointer"}},{"before":"dbfdc71d2d8087994dc26fb1acbf4e81e106e941","after":"125464f2d9bbfa587a914bcdf9b72c7727fe86c8","ref":"refs/heads/next","pushedAt":"2024-05-26T09:04:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nyh","name":"Nadav Har'El","path":"/nyh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/584227?s=80&v=4"},"commit":{"message":"migration_manager: do not reference moved-away smart pointer\n\nthis change is inspired by clang-tidy. it warns like:\n```\n[752/852] Building CXX object service/CMakeFiles/service.dir/migration_manager.cc.o\nWarning: /home/runner/work/scylladb/scylladb/service/migration_manager.cc:891:71: warning: 'view' used after it was moved [bugprone-use-after-move]\n  891 |             db.get_notifier().before_create_column_family(*keyspace, *view, mutations, ts);\n      |                                                                       ^\n/home/runner/work/scylladb/scylladb/service/migration_manager.cc:886:86: note: move occurred here\n  886 |             auto mutations = db::schema_tables::make_create_view_mutations(keyspace, std::move(view), ts);\n      |                                                                                      ^\n```\nin which,  `view` is an instance of view_ptr which is a type with the\nsemantics of shared pointer, it's backed by a member variable of\n`seastar::lw_shared_ptr<const schema>`, whose move-ctor actually resets\nthe original instance. so we are actually accessing the moved-away\npointer in\n\n```c++\ndb.get_notifier().before_create_column_family(*keyspace, *view, mutations, ts)\n```\n\nso, in this change, instead of moving away from `view`, we create\na copy, and pass the copy to\n`db::schema_tables::make_create_view_mutations()`. this should be fine,\nas the behavior of `db::schema_tables::make_create_view_mutations()`\ndoes not rely on if the `view` passed to it is a moved away from it or not.\n\nthe change which introduced this use-after-move was 88a5ddabce\n\nRefs 88a5ddabcec625434b2df0ed82a63c36245af35f\nFixes #18837\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18838","shortMessageHtmlLink":"migration_manager: do not reference moved-away smart pointer"}},{"before":"de798775fd30bd07b0cc31d0465364d3e2816e9b","after":"dbfdc71d2d8087994dc26fb1acbf4e81e106e941","ref":"refs/heads/next","pushedAt":"2024-05-26T08:54:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nyh","name":"Nadav Har'El","path":"/nyh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/584227?s=80&v=4"},"commit":{"message":"treewide: fix typos in comment and error messages\n\nthese typos were identified by codespell\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18868","shortMessageHtmlLink":"treewide: fix typos in comment and error messages"}},{"before":"3a6e37aef115b36e4b16ab75173e507c476482ec","after":null,"ref":"refs/heads/mergify/copy/branch-5.4/pr-18694","pushedAt":"2024-05-26T07:53:02.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"1b4d5d02ef899d71f9d82c753482479604bb4110","after":"d078bafa007d2b7fe1e08a5d48387c10541b494f","ref":"refs/heads/branch-6.0","pushedAt":"2024-05-26T07:51:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"Update ScyllaDB version to: 6.0.0-rc1","shortMessageHtmlLink":"Update ScyllaDB version to: 6.0.0-rc1"}},{"before":"9adf74ae6c7a150266ad8755edbcc584b112bca5","after":"de798775fd30bd07b0cc31d0465364d3e2816e9b","ref":"refs/heads/master","pushedAt":"2024-05-25T11:21:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"test: test_coordinator_queue_management: wait for logs properly\n\nThe modified lines of code intend to await the first appearance of a log\non one of the nodes.\n\nBut due to misplaced parentheses, instead of creating a list of log-awaiting\ntasks with a list comprehension, they pass a generator expression to\nasyncio.create_task().\n\nThis is nonsense, and it fails immediately with a type error.\nBut since they don't actually check the result of the await,\nthe test just assumes that the search completed successfully.\n\nThis was uncovered by an upgrade to Python 3.12, because its typing is stronger\nand asyncio.create_task() screams when it's passed a regular generator.\n\nThis patch fixes the bad list comprehension, and also adds an error check\non the completed awaitables (by calling `await` on them).\n\nFixes #18740\n\nCloses scylladb/scylladb#18754","shortMessageHtmlLink":"test: test_coordinator_queue_management: wait for logs properly"}},{"before":"9adf74ae6c7a150266ad8755edbcc584b112bca5","after":"de798775fd30bd07b0cc31d0465364d3e2816e9b","ref":"refs/heads/next","pushedAt":"2024-05-25T07:54:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"test: test_coordinator_queue_management: wait for logs properly\n\nThe modified lines of code intend to await the first appearance of a log\non one of the nodes.\n\nBut due to misplaced parentheses, instead of creating a list of log-awaiting\ntasks with a list comprehension, they pass a generator expression to\nasyncio.create_task().\n\nThis is nonsense, and it fails immediately with a type error.\nBut since they don't actually check the result of the await,\nthe test just assumes that the search completed successfully.\n\nThis was uncovered by an upgrade to Python 3.12, because its typing is stronger\nand asyncio.create_task() screams when it's passed a regular generator.\n\nThis patch fixes the bad list comprehension, and also adds an error check\non the completed awaitables (by calling `await` on them).\n\nFixes #18740\n\nCloses scylladb/scylladb#18754","shortMessageHtmlLink":"test: test_coordinator_queue_management: wait for logs properly"}},{"before":"d7afae67bae39fda9eb892fb60d2c1aa33f478be","after":"3dacf6a4b12dfc955084c82ddc161283161ad1c5","ref":"refs/heads/mergify/copy/branch-5.2/pr-18667","pushedAt":"2024-05-24T07:37:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"test/boost/mutation_fragment_test.cc: add test for validator validation levels\n\nTo make sure that the validator doesn't validate what the validation\nlevel doesn't include.\n\n(cherry picked from commit 78afb3644cb9f610bde59fd2cbafe71c9e616fbc)","shortMessageHtmlLink":"test/boost/mutation_fragment_test.cc: add test for validator validati…"}},{"before":"46926dcf80872b6cf103dc0e3a21d7f95aa47ea2","after":"321bbd093ccc675d1b241a9d9ed292d08bc36a1d","ref":"refs/heads/gh-pages","pushedAt":"2024-05-24T00:01:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Publish docs","shortMessageHtmlLink":"Publish docs"}},{"before":null,"after":"b031d9cb04ed91bfda01ed406550cdee9412f719","ref":"refs/heads/mergify/copy/branch-6.0/pr-18785","pushedAt":"2024-05-24T00:00:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"docs: remove note about performance degradation with default superuser\n\nThis doesn't apply for auth-v2 as we improved data placement and\nremoved cassandra quirk which was setting different CL for some\ndefault superuser involved operations.\n\nFixes #18773\n\n(cherry picked from commit 4400d66b70476ebcde5848747c289156a09cc3b5)","shortMessageHtmlLink":"docs: remove note about performance degradation with default superuser"}},{"before":null,"after":"a6725d10b5638f8ffcbf81e1d63428c06cc51e83","ref":"refs/heads/mergify/copy/branch-6.0/pr-18798","pushedAt":"2024-05-24T00:00:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"replica: Fix tablet's compaction_groups_for_token_range() with unowned range\n\nFile-based tablet streaming calls every shard to return data of every\ngroup that intersects with a given range.\nAfter dynamic group allocation, that breaks as the tablet range will\nonly be present in a single shard, so an exception is thrown causing\nmigration to halt during streaming phase.\nIdeally, only one shard is invoked, but that's out of the scope of this\nfix and compaction_groups_for_token_range() should return empty result\nif none of the local groups intersect with the range.\n\nSigned-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>\n(cherry picked from commit deef9cf91cf5811f3225cc5c1090d35b26e77cff)","shortMessageHtmlLink":"replica: Fix tablet's compaction_groups_for_token_range() with unowne…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVKZG5AA","startCursor":null,"endCursor":null}},"title":"Activity · scylladb/scylladb"}