Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer parameters in sq.gr.spatial_neighbors when only one choice #876

Open
timtreis opened this issue Aug 21, 2024 · 1 comment
Open

Infer parameters in sq.gr.spatial_neighbors when only one choice #876

timtreis opened this issue Aug 21, 2024 · 1 comment
Assignees

Comments

@timtreis
Copy link
Member

I'm working on tutorial notebooks right now and ran into a minor hiccup when running sq.gr.spatial_neighbors(). @giovp already ported the function to work with spatialdata (thanks!) but the function requires manual input of the parameters elements_to_coordinate_systems and table_key, even if those are the only options.

I propose to automatically infer these instead when there are no other choices anyway and just notify the user of that fact. Any objections?

sq.gr.spatial_neighbors(
    sdata_merfish,
    elements_to_coordinate_systems={"cells": "global"},
    table_key="table"
)
@giovp
Copy link
Member

giovp commented Aug 23, 2024

sounds great! defaults are convenient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants