Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zappy compatibility for clip_array #3317

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Fix zappy compatibility for clip_array #3317

merged 8 commits into from
Nov 11, 2024

Conversation

flying-sheep
Copy link
Member

  • Closes #
  • Tests included or not required because:
  • Release notes not necessary because:

@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.58%. Comparing base (a227c12) to head (ae8bd60).

Files with missing lines Patch % Lines
src/scanpy/preprocessing/_scale.py 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3317      +/-   ##
==========================================
- Coverage   76.58%   76.58%   -0.01%     
==========================================
  Files         111      111              
  Lines       12863    12862       -1     
==========================================
- Hits         9851     9850       -1     
  Misses       3012     3012
Files with missing lines Coverage Δ
src/scanpy/_utils/__init__.py 76.20% <ø> (ø)
src/scanpy/preprocessing/_scale.py 78.94% <92.30%> (-0.16%) ⬇️

@ilan-gold ilan-gold mentioned this pull request Oct 25, 2024
Merged
3 tasks
@flying-sheep flying-sheep added this to the 1.10.4 milestone Oct 25, 2024
@flying-sheep flying-sheep changed the title Avoid parallel numba within dask Fix zappy compatibility for clip_array Nov 5, 2024
@flying-sheep flying-sheep modified the milestones: 1.10.4, 1.11.0 Nov 7, 2024
@flying-sheep flying-sheep marked this pull request as ready for review November 7, 2024 12:17
ilan-gold
ilan-gold approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about zappy but it's certainly cleaner

src/scanpy/preprocessing/_scale.py Show resolved Hide resolved
@flying-sheep flying-sheep merged commit 6dd0a7a into main Nov 11, 2024
4 of 12 checks passed
@flying-sheep flying-sheep deleted the fix-clip-dask-sparse branch November 11, 2024 13:33
flying-sheep added a commit that referenced this pull request Nov 11, 2024
@flying-sheep
Backport PR #3317: Fix zappy compatibility for clip_array
5e331fe
@scverse scverse deleted a comment from lumberbot-app bot Nov 11, 2024
flying-sheep added a commit that referenced this pull request Nov 12, 2024
@flying-sheep
Backport PR #3317 on branch 1.10.x (Fix zappy compatibility for clip_…
24959bd 
…array) (#3352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilan-gold ilan-gold ilan-gold approved these changes

Assignees
No one assigned
Labels
Development Process 🚀
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
2 participants
@flying-sheep @ilan-gold