-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UMAP implementation in igraph #3408
Comments
Hello, I'd be glad to provide this enhancement and joining the project. Can you assign this issue to me? Thanks |
Sure, I assigned you for now! Please note
Regarding design, there are two considerations you can engage with if you want:
If you want to have a call with us about how to best design an API around all that (or about which parts you want to leave out), please tell us. If you already have a straightforward idea about what to do, please go ahead! |
Thanks both. Note that scanpy already has the two step process in place internally, and you could swap igraph for either or both steps. Actually it's three steps, the first one being the creation of the knn graph. Scanpy already resected that chunk out of the official UMAP implementation for performance reasons. Let me know if I can help |
What kind of feature would you like to request?
Additional function parameters / changed functionality / changed defaults?
Please describe your wishes
dear devs,
Thank you for maintaining scanpy, which is a great piece of software.
I am a core developer of igraph and around a year ago we started providing an implementation of UMAP. It is accessible via the igraph Python package and the actual computations run entirely in C. This is designed to be an alternative to the original UMAP implementation that requires numba, llvmlite, etc. Since scanpy relies on igraph for clustering already, this might be useful for folks who have trouble with the dependency stack.
Just like Leiden clustering can now use either leidenalg or directly igraph, it would be nice to let people choose
flavor='igraph'
for embedding as well.Our implementation requires as input a nearest neighbor graph with distances and has two parts, just like the original umap:
Would you be interested in this? If so, I can make a PR for scanpy and perhaps one of you can review it?
The text was updated successfully, but these errors were encountered: