From 2dda70c7e088d4b741e36b2bf7d0bf4bf798b9cb Mon Sep 17 00:00:00 2001 From: ilan-gold Date: Thu, 14 Nov 2024 14:30:56 +0100 Subject: [PATCH 1/3] (chore): remove `anndata.read` --- src/anndata/__init__.py | 13 ------------- tests/test_deprecations.py | 12 +----------- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/src/anndata/__init__.py b/src/anndata/__init__.py index fec027c87..b874a66e0 100644 --- a/src/anndata/__init__.py +++ b/src/anndata/__init__.py @@ -45,18 +45,6 @@ # We use these in tests by attribute access from . import logging # noqa: F401, E402 isort: skip - -def read(*args, **kwargs): - import warnings - - warnings.warn( - "`anndata.read` is deprecated, use `anndata.read_h5ad` instead. " - "`ad.read` will be removed in mid 2024.", - FutureWarning, - ) - return read_h5ad(*args, **kwargs) - - _DEPRECATED_IO = ( "read_loom", "read_hdf", @@ -89,7 +77,6 @@ def __getattr__(attr_name: str) -> Any: "concat", "read_zarr", "read_h5ad", - "read", # Warnings "OldFormatWarning", "WriteWarning", diff --git a/tests/test_deprecations.py b/tests/test_deprecations.py index b5cc44c29..73350bc43 100644 --- a/tests/test_deprecations.py +++ b/tests/test_deprecations.py @@ -14,7 +14,7 @@ from scipy import sparse import anndata.experimental -from anndata import AnnData, read +from anndata import AnnData from anndata.tests.helpers import assert_equal @@ -117,16 +117,6 @@ def test_deprecated_write_attribute(tmp_path): assert_equal(A, attribute_A) -def test_deprecated_read(tmp_path): - memory = AnnData(np.random.randn(20, 10)) - memory.write_h5ad(tmp_path / "file.h5ad") - - with pytest.warns(FutureWarning, match=r"`anndata.read` is deprecated"): - from_disk = read(tmp_path / "file.h5ad") - - assert_equal(memory, from_disk) - - @pytest.mark.parametrize( ("old_name", "new_name", "module"), ( From f13a12a57ef71ff51929a3ded5e7db5759c4ac90 Mon Sep 17 00:00:00 2001 From: ilan-gold Date: Thu, 14 Nov 2024 14:38:47 +0100 Subject: [PATCH 2/3] (chore): release note --- docs/release-notes/1766.breaking.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/release-notes/1766.breaking.md diff --git a/docs/release-notes/1766.breaking.md b/docs/release-notes/1766.breaking.md new file mode 100644 index 000000000..a976dbbc8 --- /dev/null +++ b/docs/release-notes/1766.breaking.md @@ -0,0 +1 @@ +Remove {func}`anndata.read` {user}`ilan-gold` From 31bd63caa926c12798c390423ea6ec53f0ba0898 Mon Sep 17 00:00:00 2001 From: ilan-gold Date: Thu, 14 Nov 2024 15:45:41 +0100 Subject: [PATCH 3/3] (chore): remove broken link --- docs/release-notes/1766.breaking.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/release-notes/1766.breaking.md b/docs/release-notes/1766.breaking.md index a976dbbc8..165d3d69e 100644 --- a/docs/release-notes/1766.breaking.md +++ b/docs/release-notes/1766.breaking.md @@ -1 +1 @@ -Remove {func}`anndata.read` {user}`ilan-gold` +Remove `anndata.read` {user}`ilan-gold`