feat: handle codec v8 #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thegaram
previously approved these changes
Jul 15, 2025
There was a problem hiding this comment.
No changes in decoding, but there might be some subtleties around decompression / zstd version, please check with @colinlyguo.
|
@colinlyguo any changes that would be required on the decompression side? I think I need to pin |
Decompression is compatible. The da-codec repo also uses the same decompressor, so LGTM. |
colinlyguo
previously approved these changes
Jul 15, 2025
|
got it thanks! I'll just pin zstd to 0.13.3 to be sure we don't accidentally bump it. |
frisitano
previously approved these changes
Jul 15, 2025
greged93
dismissed stale reviews from frisitano, colinlyguo, and Thegaram
via
05a47ae
Thegaram
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afaiu from l2geth, it doesn't seem like decoding as changed for codec v8.
Resolves #152.