Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Share icon also rotating with it's container #108

Open
gupta-ji6 opened this issue Jan 10, 2023 · 1 comment
Open

Mobile: Share icon also rotating with it's container #108

gupta-ji6 opened this issue Jan 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gupta-ji6
Copy link
Member

gupta-ji6 commented Jan 10, 2023

Description

There's a share button visible only for mobile devices. I recently observed that the share icon also now rotates with the container, which wasn't the case before. Probably some tailwind upgrade might have caused this.

P.S. This might be happening just in Safari, need to check on Chrome engine too once.
https://user-images.githubusercontent.com/21218732/211520400-6205fc43-8461-464f-8333-3ea2f0c50aea.MP4

Expectation

Only the button container should rotate, not the icon.

@gupta-ji6 gupta-ji6 changed the title Mobile: Share icon rotation Mobile: Share icon also rotating with it's container Jan 10, 2023
@technetium-co technetium-co added the bug Something isn't working label Jan 10, 2023
@hussamkhatib
Copy link
Contributor

Hey, could you explain me how the rotation would look like ? It looks like you dont really need the animate-spin-slow class, it is just rotating the ShareIconButton and not the container.

https://github.com/scriptified/scriptified.dev/blob/b5b5185434e9d1738eedca0260b9e41c36e72b03/components/common/FloatingShareButton.tsx#LL69C9-L69C18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants