Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing punctutation #11

Closed
2 tasks done
RyanPaulGannon opened this issue Sep 4, 2024 · 3 comments
Closed
2 tasks done

Missing punctutation #11

RyanPaulGannon opened this issue Sep 4, 2024 · 3 comments
Assignees
Labels
design Relates to UX/UI designs good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@RyanPaulGannon
Copy link
Collaborator

Terms

Description

Located within lib.rs lives our function allowed_keys which is currently populated with the 26 English alphabet characters, 0-9 and some English punctuation. For now, we need to add in the remaining punctuation, for example we are missing apostrophes.

I think these are located in rdev::Key which we are already using, so if so, it should be fairly straight forward to implement. Eventually we may need to look at splitting this up as we expand the language sets, but for now, filling out this function should be enough to close this issue.

Contribution

I think this should be a fairly simple issue for someone new to the language to accomplish, I will take a look further in to the rdev crate anyway, if nobody takes this after a short time I will pick it up :)

@RyanPaulGannon RyanPaulGannon added design Relates to UX/UI designs good first issue Good for newcomers labels Sep 4, 2024
@andrewtavis andrewtavis added the help wanted Extra attention is needed label Sep 4, 2024
@henrikth93
Copy link
Member

I am interested in this

@henrikth93 henrikth93 self-assigned this Sep 24, 2024
@andrewtavis
Copy link
Member

Let us know how it's going, @henrikth93!

@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Oct 1, 2024
@andrewtavis
Copy link
Member

Closed by #13 :) Thanks for a great first contribution, @KesharwaniArpita! 😊

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Relates to UX/UI designs good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

3 participants