Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check Before Deleting File in Workflow #336

Open
2 tasks done
SethiShreya opened this issue Oct 13, 2024 · 3 comments
Open
2 tasks done

Fix: Check Before Deleting File in Workflow #336

SethiShreya opened this issue Oct 13, 2024 · 3 comments
Assignees
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@SethiShreya
Copy link
Contributor

Terms

Description

Currently, the workflow deletes the file first and then extracts the data. This approach causes an issue where if an error occurs during data extraction, the previous file is already deleted and no new data is added, resulting in data loss.

Steps to Reproduce:

  • Run the following command:
    scribe-data get --lang german -dt nouns

  • Carefully observe the workflow:
    a. The file is deleted first.
    b. Then the data extraction process begins.
    c. If any error occurs during the data extraction, no new data is added, and the previous file is already deleted.

Expected Behavior: The system should first verify whether the data extraction process is successful before deleting the file. If the data extraction is error-free, then the file should be deleted.

Proposed Fix:

  • Add a checking mechanism before deleting the file.
  • Only proceed with file deletion if the data extraction process completes successfully without errors.

Impact: This will prevent unnecessary data loss in case of errors during the extraction phase.

Contribution

No response

@SethiShreya SethiShreya added the feature New feature or request label Oct 13, 2024
@andrewtavis andrewtavis added help wanted Extra attention is needed hacktoberfest Included as a part of Hacktoberfest labels Oct 13, 2024
@andrewtavis
Copy link
Member

Thanks for the issue, @SethiShreya!

@andrewtavis
Copy link
Member

@SethiShreya: Do you think that including totals lexemes regardless of data type in the total output makes sense? maybe as the first row of the table? Let me know and I can make an issue for it :)

@Otom-obhazi
Copy link
Contributor

can i help??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

3 participants