Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Punjabi language queries #271

Open
8 tasks done
SethiShreya opened this issue Oct 7, 2024 · 11 comments
Open
8 tasks done

Create Punjabi language queries #271

SethiShreya opened this issue Oct 7, 2024 · 11 comments
Assignees
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@SethiShreya
Copy link
Contributor

SethiShreya commented Oct 7, 2024

Terms

Description

This issue would look into expanding the src/scribe_data/language_data_extraction/Punjabi files with as much data as are possible from the current data on Wikidata. We can use code for getting data from other languages, and from there we can check Punjabi data on Wikidata for what conjugations are available. We can then expand the query with optional selections of certain forms as is done in other SPARQL queries. The query can be tried on the Wikidata Query Service UI during development :)

Data types to include:

  • Nouns
  • Verbs
  • Adjectives
  • Adverbs
  • Prepositions
  • Emoji keywords

Contribution

I will start with creating nouns, gender and verb queries for Punjabi and then will take it further to add conjugations and other stuffs.

@SethiShreya SethiShreya added the feature New feature or request label Oct 7, 2024
@andrewtavis andrewtavis added help wanted Extra attention is needed hacktoberfest Included as a part of Hacktoberfest labels Oct 7, 2024
@andrewtavis
Copy link
Member

Thanks for the issue, @SethiShreya! :)

@SethiShreya
Copy link
Contributor Author

SethiShreya commented Oct 8, 2024

Added Sparql query for Punjabi language nouns, so when I was searching I found while extracting the nouns for punjabi language, it was extracting for Gurmukhi (Punjabi language for India) and Shahmukhi (Punjabi language for Muslims), So I added filter only to get Gurmukhi with tag ("pa").
The query also included the Gender, plural and singular nouns for Gurmukhi. I have tested it on website and in the code too.

@andrewtavis Please review and give your feedbacks

@andrewtavis
Copy link
Member

Hey @SethiShreya 👋 Interesting to learn all of this. Recently we've been discussing moving some languages to a common sub directory so it's a bit more organized, so would you say that we could have a Punjabi directory and have Gurmukhi and Shahmukhi sub directories? The same can be seen now in Norwegian :) Let me know. I'll review the current PR as is :)

@SethiShreya
Copy link
Contributor Author

SethiShreya commented Oct 9, 2024

Hey @SethiShreya 👋 Interesting to learn all of this. Recently we've been discussing moving some languages to a common sub directory so it's a bit more organized, so would you say that we could have a Punjabi directory and have Gurmukhi and Shahmukhi sub directories? The same can be seen now in Norwegian :) Let me know. I'll review the current PR as is :)

That would be good, so directory structure will be

Punjabi
-----Gurmukhi
-----Shahmukhi

Right?
Then i guess we would need to change code too to run these sub directory queries too i guess

@andrewtavis
Copy link
Member

Yes, exactly. We'll do this maybe in a week as the new directories can't be run anyway :) Feel free to change the structure in your next PR!

@andrewtavis
Copy link
Member

Just added a list of data types that we want to include to this issue :) We can maybe do all of this for Gurmukhi and Shahmukhi, @SethiShreya 😊

@SethiShreya
Copy link
Contributor Author

Thanks @andrewtavis, sure i will work on those data types and on the directory structure too.

@andrewtavis
Copy link
Member

Sounds great, @SethiShreya! :)

@SethiShreya
Copy link
Contributor Author

@andrewtavis i have bifurcated directory to Gurmukhi and Shahmukhi added verb query and fixed directory structure to call these too. Raised a PR here, please check once. Checked it on my end.

please review and give your feedback, Thanks :)

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Oct 12, 2024
andrewtavis added a commit that referenced this issue Oct 24, 2024
@andrewtavis
Copy link
Member

Sent along the base versions of the rest of the queries in f14a335, @SethiShreya :) Let me know if you'd like to expand them with their forms :)

@SethiShreya
Copy link
Contributor Author

Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

2 participants