Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and implement LIMIT and OFFSET within queries #156

Open
2 tasks done
andrewtavis opened this issue Jun 15, 2024 · 3 comments
Open
2 tasks done

Investigate and implement LIMIT and OFFSET within queries #156

andrewtavis opened this issue Jun 15, 2024 · 3 comments
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jun 15, 2024

Terms

Description

This issue is a new version of the deleted #130 that came from #124, and also is related to #68. Scribe will at one point likely need to have LIMIT and OFFSET within the queries such that they can finish. As of now a solution was found for the issue in #124, but there could come a time when the queries would not finish. Figuring this out would allow us to have confidence that the query process for Scribe-Data is robust, regardless of the size of the Wikidata Query Service response.

Contribution

Would be very happy to investigate this going forward and help implement. The general idea was that we would query the total for a language and word type pair and then break the query down with LIMIT and OFFSET being iterated over based on the total number of results. Keeping the total returned to ~50,000 should be fine, but we can also test this with different queries.

Note that this issue is not of high priority, but could be something that we look at later :)

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Jun 15, 2024
@andrewtavis
Copy link
Member Author

CC @wkyoshida 😊

@henrikth93
Copy link
Member

I am interested in this!

@andrewtavis
Copy link
Member Author

Hey @henrikth93 👋 Let's maybe hold off on this one until GSoC's all done, as there's no real need for it now :) We can discuss in the sync or a call between the two of us what might be the best next thing to work on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants