-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve unhandled exception handling for Crawler*.crawl() #6047
Comments
Hey @wRAR I'm on point with the description. I think I can work on it so I'll really appreciate if you can assign this issue to me. Also I had just one doubt, this issue only focuses on adding errbacks in the docs right ?? |
"either in our code or in examples" so no, ideally it should be done in the code. |
Related (but is about |
Could I work on this? |
Sure. |
Hi! @yueric985 and I are students are we are working on a project for a class that requires us to make an open-source contribution to a library. We will be working on this issue as an example. |
As we recently found in #6038, the following well-known snippet from docs and tests:
doesn't handle exceptions raised in crawl() correctly, as that method returns a Deferred and we should add an errback to it instead of relying on https://docs.twisted.org/en/latest/core/howto/defer.html#unhandled-errors, either in our code or in examples.
The text was updated successfully, but these errors were encountered: