Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into changing the way we include the compiler plugin #333

Open
ckipp01 opened this issue May 2, 2021 · 1 comment
Open

Look into changing the way we include the compiler plugin #333

ckipp01 opened this issue May 2, 2021 · 1 comment

Comments

@ckipp01
Copy link
Member

ckipp01 commented May 2, 2021

Currently we are actually just including both the scalac-scoverage-runtime and the scalac-scoverage-plugin as library dependencies. Then we later check the dependencies to see if it's there, grab the location of the compiler plugin, and then include it with -Xplugin.

Some(s"-Xplugin:${pluginPath.getAbsolutePath}"),

I'm trying to get a bit more familiar with anything before making any real changes, but I believe we instead might be able to just utilize addCompilerPlugin to make this a bit easier.

@nafg
Copy link

nafg commented Jun 6, 2021

That's probably the same thing just shorter. I would test it by making the change and comparing the resulting scalac command line, either with export compile or with a task manager like ps while it's running.

One difference is IIRC addCompilerPlugin may set the dependency scope. What config is in the current libraryDependencies setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants