Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use composite widgets instead of only inheriting from VBox/HBox #406

Open
nvaytet opened this issue Jan 28, 2025 · 0 comments
Open

Use composite widgets instead of only inheriting from VBox/HBox #406

nvaytet opened this issue Jan 28, 2025 · 0 comments

Comments

@nvaytet
Copy link
Member

nvaytet commented Jan 28, 2025

Our custom widgets have a _plopp_observe method instead of observe because inheriting from VBox causes errors when overriding the observe method (see e.g. https://github.com/scipp/plopp/blob/main/src/plopp/widgets/slice.py#L73)

However, it is possible to work around this by also inheriting from ValueWidget. See jupyter-widgets/ipywidgets#2839 (comment)

This would make our implementation cleaner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvaytet