Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load monitors separately from the remainder of the files #99

Closed
SimonHeybrock opened this issue Feb 26, 2024 · 0 comments · Fixed by #104
Closed

Load monitors separately from the remainder of the files #99

SimonHeybrock opened this issue Feb 26, 2024 · 0 comments · Fixed by #104
Assignees
Milestone

Comments

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Feb 26, 2024

This is a subtask of #82, which is easy to implement in isolation. The required monitors should be loaded independently, without loading the rest of the file.

  • Load each monitor on its own, not all together.
  • You can assume that all monitors are direct children of NXentry/NXinstrument. The monitor names are defined in the workflow.
  • You can assume that position information is self-contained, i.e., there are no depends_on chains leading outside a monitor. We can thus directly use snx.compute_positions on the individual monitor.
  • Add a filter to the existing load function such that no monitors are loaded there. This is essential to avoid potential massive overhead from large event-mode monitors.
  • The functions for "extracting" monitors for the loaded data probably need to preserved for supporting legacy NeXus files (ISIS). They should be moved to that submodule if feasible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants