Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki gets lab-frame transform for solid angle from uncalibrated detector position #174

Closed
SimonHeybrock opened this issue Oct 3, 2024 · 0 comments · Fixed by #178
Closed
Assignees
Labels
bug Something isn't working

Comments

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Oct 3, 2024

See

def detector_lab_frame_transform(
detector: NeXusDetector[ScatteringRunType],
transform_path: TransformationPath,
) -> LabFrameTransform[ScatteringRunType]:
return LabFrameTransform[ScatteringRunType](detector[transform_path])

I don't know if this was done correctly in the past and broken in some graph restructure, or if it was always wrong?

As this part of the NeXus workflow is currently being refactored in scipp/essreduce#114 I will fix it as part of those updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant