Skip to content

[py314] Use filter argument for extracting data from registry #289

@YooSunYoung

Description

@YooSunYoung

I recently cleaned cache and re-downloaded pooch datasets using the latest dependencies installed.

I got this DeprecationWarning about the tar file extraction.
I guess it's sth we should fix?
It's not easy to reproduce since the cache should be cleaned...

.tox/py313/lib/python3.13/site-packages/ess/nmx/data/__init__.py:60: in get_small_mtz_samples
    return _registry.get_paths("mtz_samples.tar.gz")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py313/lib/python3.13/site-packages/ess/reduce/data/_registry.py:207: in get_paths
    return [Path(path) for path in self._fetch(name, extractor=extractor)]
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py313/lib/python3.13/site-packages/ess/reduce/data/_registry.py:247: in _fetch
    return self._registry.fetch(name, processor=extractor)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py313/lib/python3.13/site-packages/pooch/core.py:599: in fetch
    return processor(str(full_path), action, self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.tox/py313/lib/python3.13/site-packages/pooch/processors.py:121: in __call__
    self._extract_file(fname, self.extract_dir)
.tox/py313/lib/python3.13/site-packages/pooch/processors.py:262: in _extract_file
    tar_file.extractall(path=extract_dir)
../../../miniconda3/envs/nmx-dev-313/lib/python3.13/tarfile.py:2338: in extractall
    filter_function = self._get_filter_function(filter)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../miniconda3/envs/nmx-dev-313/lib/python3.13/tarfile.py:2303: in _get_filter_function
    warnings.warn(
E   DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions