Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package structure for subtechniques #9

Closed
jl-wynen opened this issue Dec 6, 2023 · 1 comment · Fixed by #39
Closed

Package structure for subtechniques #9

jl-wynen opened this issue Dec 6, 2023 · 1 comment · Fixed by #39
Assignees

Comments

@jl-wynen
Copy link
Member

jl-wynen commented Dec 6, 2023

The current intention is that ESSdiffraction contains code for both powder and single crystal. But at this point, no SXD code has been added. Some existing code is provided in the root ess.diffraction package while some other functions are in ess.diffraction.powder.

It is unclear at this point what code can be shared between the techniques. The current split is based on a guess made in the old ess project and likely needs to be revised.

This is not a huge deal for regular functions and classes as those can easily be imported from wherever they are. But for Sciline providers, the split is more important because domain types used in the common ess.diffraction.providers must match pipelines in both powder and SXD. It is possible that we need to remove the shared provider list and only provide ess.diffraction.{powder,sxd}.providers.

See also this thread: #7 (comment)

@SimonHeybrock
Copy link
Member

How about

ess.diffraction  #common
ess.powder
ess.sxd
ess.dream
ess.magic

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants