Fix trivial infeasibility

Author: DominikKamp

.gitlab-ci.yml

@@ -47,7 +47,7 @@ boost-soplex-scip:
     - export CFLAGS=""
     - export CXXFLAGS=""
     # boost
-    - wget https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VERSION}/source/boost_$(echo ${BOOST_VERSION} | tr . _).tar.gz -O ${BOOST_DIR}.tar.gz
+    - wget https://archives.boost.io/release/${BOOST_VERSION}/source/boost_$(echo ${BOOST_VERSION} | tr . _).tar.gz -O ${BOOST_DIR}.tar.gz
     - mkdir -p ${BOOST_DIR}
     - tar -xzf ${BOOST_DIR}.tar.gz -C ${BOOST_DIR} --strip-components=1
     - cd ${BOOST_DIR}

CHANGELOG

@@ -21,6 +21,7 @@ Fixed bugs
 ----------
 
 - keep restricted solver limit settings in modifier setting when resetting
+- avoid fixing trivially infeasible bounds and sides to keep feasibility status
 
 Build system
 ------------

src/bugger/modifiers/CoefficientModifier.hpp

@@ -50,7 +50,7 @@ namespace bugger
          return !problem.getColFlags( )[ col ].test(ColFlag::kFixed)
              && !problem.getColFlags( )[ col ].test(ColFlag::kLbInf)
              && !problem.getColFlags( )[ col ].test(ColFlag::kUbInf)
-             && this->num.isZetaEq(problem.getLowerBounds( )[ col ], problem.getUpperBounds( )[ col ]);
+             && this->num.isZetaGE(problem.getLowerBounds( )[ col ], problem.getUpperBounds( )[ col ]);
       }
 
       bool

src/bugger/modifiers/ConsroundModifier.hpp

@@ -53,7 +53,9 @@ namespace bugger
          bool rhsinf = problem.getRowFlags( )[ row ].test(RowFlag::kRhsInf);
          REAL lhs { problem.getConstraintMatrix( ).getLeftHandSides( )[ row ] };
          REAL rhs { problem.getConstraintMatrix( ).getRightHandSides( )[ row ] };
-         if( ( lhsinf || rhsinf || !this->num.isZetaEq(lhs, rhs) ) && ( ( !lhsinf && !this->num.isZetaIntegral(lhs) ) || ( !rhsinf && !this->num.isZetaIntegral(rhs) ) ) )
+         if( ( lhsinf || rhsinf || !this->num.isZetaEq(lhs, rhs) )
+          && ( ( !lhsinf && !this->num.isZetaIntegral(lhs) )
+            || ( !rhsinf && !this->num.isZetaIntegral(rhs) ) ) )
             return true;
          const auto& data = problem.getConstraintMatrix( ).getRowCoefficients(row);
          for( int index = 0; index < data.getLength( ); ++index )

src/bugger/modifiers/ObjectiveModifier.hpp

@@ -47,10 +47,11 @@ namespace bugger
       bool
       isObjectiveAdmissible(const Problem<REAL>& problem, const int& col) const
       {
-         return !this->num.isZetaZero(problem.getObjective( ).coefficients[ col ])
-           && ( problem.getColFlags( )[ col ].test(ColFlag::kLbInf)
-             || problem.getColFlags( )[ col ].test(ColFlag::kUbInf)
-             || !this->num.isZetaEq(problem.getLowerBounds( )[ col ], problem.getUpperBounds( )[ col ]) );
+         return !problem.getColFlags( )[ col ].test(ColFlag::kFixed)
+             && !this->num.isZetaZero(problem.getObjective( ).coefficients[ col ])
+             && ( problem.getColFlags( )[ col ].test(ColFlag::kLbInf)
+               || problem.getColFlags( )[ col ].test(ColFlag::kUbInf)
+               || !this->num.isZetaEq(problem.getLowerBounds( )[ col ], problem.getUpperBounds( )[ col ]) );
       }
 
       ModifierStatus

src/bugger/modifiers/SideModifier.hpp

@@ -48,9 +48,9 @@ namespace bugger
       isSideAdmissible(const Problem<REAL>& problem, const int& row) const
       {
          return !problem.getRowFlags( )[ row ].test(RowFlag::kRedundant)
-           && ( problem.getRowFlags( )[ row ].test(RowFlag::kLhsInf)
-             || problem.getRowFlags( )[ row ].test(RowFlag::kRhsInf)
-             || !this->num.isZetaEq(problem.getConstraintMatrix( ).getLeftHandSides( )[ row ], problem.getConstraintMatrix( ).getRightHandSides( )[ row ]) );
+             && ( problem.getRowFlags( )[ row ].test(RowFlag::kLhsInf)
+               || problem.getRowFlags( )[ row ].test(RowFlag::kRhsInf)
+               || this->num.isZetaLT(problem.getConstraintMatrix( ).getLeftHandSides( )[ row ], problem.getConstraintMatrix( ).getRightHandSides( )[ row ]) );
       }
 
       ModifierStatus

src/bugger/modifiers/VariableModifier.hpp

@@ -47,9 +47,10 @@ namespace bugger
       bool
       isVariableAdmissible(const Problem<REAL>& problem, const int& col) const
       {
-         return problem.getColFlags( )[ col ].test(ColFlag::kLbInf)
-             || problem.getColFlags( )[ col ].test(ColFlag::kUbInf)
-             || !this->num.isZetaEq(problem.getLowerBounds( )[ col ], problem.getUpperBounds( )[ col ]);
+         return !problem.getColFlags( )[ col ].test(ColFlag::kFixed)
+             && ( problem.getColFlags( )[ col ].test(ColFlag::kLbInf)
+               || problem.getColFlags( )[ col ].test(ColFlag::kUbInf)
+               || this->num.isZetaLT(problem.getLowerBounds( )[ col ], problem.getUpperBounds( )[ col ]) );
       }
 
       ModifierStatus

src/bugger/modifiers/VarroundModifier.hpp

@@ -55,7 +55,9 @@ namespace bugger
          bool ubinf = problem.getColFlags( )[ col ].test(ColFlag::kUbInf);
          REAL lb { problem.getLowerBounds( )[ col ] };
          REAL ub { problem.getUpperBounds( )[ col ] };
-         return ( lbinf || ubinf || !this->num.isZetaEq(lb, ub) ) && ( ( !lbinf && !this->num.isZetaIntegral(lb) ) || ( !ubinf && !this->num.isZetaIntegral(ub) ) );
+         return ( lbinf || ubinf || !this->num.isZetaEq(lb, ub) )
+             && ( ( !lbinf && !this->num.isZetaIntegral(lb) )
+               || ( !ubinf && !this->num.isZetaIntegral(ub) ) );
       }
 
       ModifierStatus