Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python-3.7-specific code once scyjava stops supporting it #57

Open
gselzer opened this issue Mar 20, 2023 · 3 comments
Open

Remove Python-3.7-specific code once scyjava stops supporting it #57

gselzer opened this issue Mar 20, 2023 · 3 comments

Comments

@gselzer
Copy link
Member

gselzer commented Mar 20, 2023

Python 3.7 will reach end-of-life in June. With that in mind, we should bump the minimum Python version to 3.8.

When doing so, we might want to grep for any hacks we have for Python 3.7. For example, this conditional (this was the main reason I'm writing this issue, because it would be nice to get rid of this 😅)

@ctrueden
Copy link
Member

ctrueden commented Mar 20, 2023

Why do we need to ditch support for Python 3.7? To reduce the size of the CI matrix? Any other reasons to do it proactively (i.e. when it's not causing any problems), as opposed to reactively (i.e. when a problem crops up due to our continued support for 3.7)?

@gselzer
Copy link
Member Author

gselzer commented Mar 20, 2023

I actually would also prefer to do it reactively, like I said in the issue I just wanted to remember to delete that conditional when we eventually do need to bump the version 😅

@ctrueden ctrueden changed the title Bump minimum Python version to 3.8 Remove Python-3.7-specific code once scyjava stops supporting it Mar 20, 2023
@ctrueden ctrueden added this to the unscheduled milestone Mar 20, 2023
@ctrueden
Copy link
Member

@gselzer Sounds good, I changed the title accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants