Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup and refactoring after switch to json #5

Open
tomburke-rse opened this issue Apr 20, 2022 · 0 comments
Open

Code cleanup and refactoring after switch to json #5

tomburke-rse opened this issue Apr 20, 2022 · 0 comments

Comments

@tomburke-rse
Copy link
Collaborator

There seems like a lot of code repetition in this else block. Can we just always populate the labelSets like above, and then populate labelMapping if the labels are not Integers?

Originally posted by @gselzer in #3 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomburke-rse