Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic HTML tags #133

Open
3 tasks
SaptakS opened this issue Jan 20, 2023 · 0 comments
Open
3 tasks

Use semantic HTML tags #133

SaptakS opened this issue Jan 20, 2023 · 0 comments

Comments

@SaptakS
Copy link
Contributor

SaptakS commented Jan 20, 2023

There are few items which I feel can benefit from better HTML tags. Ideally we can maybe update the CSS to be applied on tag instead of a class in the design system if there is a fixed style for the elements, but I don't mind keeping the designs in class instead of HTML tags. Some elements I noticed:

  • Highlighted text: Let's use <mark> for anywhere we are using highlighted text.
  • Striked out text: Let's use <s> for striked out text, e.g. prices
  • <div role="main"> : Let's replace this with <main>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant