Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading? #844

Open
Javi3rV opened this issue Nov 14, 2024 · 6 comments
Open

Multithreading? #844

Javi3rV opened this issue Nov 14, 2024 · 6 comments

Comments

@Javi3rV
Copy link

Javi3rV commented Nov 14, 2024

What about adding configurable threads number? For many files we know we can use --zip, but I tested croc with a 800mb file and it was slower than I expected. Here is where multi threading would help, I think sending or receiving the file with 5 or 10 individual threads would speed it up a lot.

I dont know if this is because of public relay (I feel lazy to configure my own server and use it as a relay).

@schollz
Copy link
Owner

schollz commented Nov 15, 2024

croc uses multi threading. bottleneck is your network connection

@Javi3rV
Copy link
Author

Javi3rV commented Nov 15, 2024

How do you recommend to test my net speed? I would like to check it so I can see if it is my net fault

@schollz
Copy link
Owner

schollz commented Nov 15, 2024

Run with croc --no-multi

@Javi3rV
Copy link
Author

Javi3rV commented Nov 21, 2024

It says flag provided but not defined

@schollz
Copy link
Owner

schollz commented Nov 21, 2024

i meant croc send --no-multi

@Javi3rV
Copy link
Author

Javi3rV commented Nov 21, 2024

Oh, makes sense. There is actually a difference in speed, btw it would be nice to have a parameter to configure the number of threads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants