Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation to other languages #78

Open
schmich opened this issue Oct 8, 2017 · 41 comments
Open

Translation to other languages #78

schmich opened this issue Oct 8, 2017 · 41 comments
Labels
hacktoberfest Digital Ocean Hacktoberfest help wanted

Comments

@schmich
Copy link
Owner

schmich commented Oct 8, 2017

Welcome

Marinara is a free Pomodoro time management assistant extension for Google Chrome with over 300,000 weekly users.

The GitHub community has helped translate this extension into over 30 languages, but some languages are still missing (see below).

How to Contribute

  1. Check the open pull requests to make sure there's not already an outstanding PR for the language you're targeting (it can take a few days for me to incorporate PRs).

  2. Use the Marinara Localization tool and follow the Translation Guide.

  3. Add yourself to CONTRIBUTORS.md.

Missing Languages

Marinara is missing translations for the following languages:

ID Language
am Amharic
bg Bulgarian
et Estonian
fil Filipino
gu Gujarati
hi Hindi
hr Croatian
hu Hungarian
kn Kannada
lv Latvian
ml Malayalam
sl Slovenian
ta Tamil
@ofou
Copy link
Contributor

ofou commented Oct 15, 2017

I'm a native Spanish speaker (Chilean) and I'll be happyto help you out with the translation.

@joselcvarela
Copy link
Contributor

joselcvarela commented Oct 15, 2017

@schmich I already told you, you can count on me for portuguese translations ;)
What do you think about to put the label Hacktoberfest on this? We could translate to much more languages

@joselcvarela
Copy link
Contributor

joselcvarela commented Oct 17, 2017

HI @schmich,
I already started working on this, but I have a question. Do we need to translate message and description or just message keys?
Also, I just noticed this translations doesn't include the settings page.

@schmich
Copy link
Owner Author

schmich commented Oct 17, 2017

You only need to translate the message values. The description is just to give you some context to assist with translation.

Also, some messages are parameterized with $parameter$. In this case, too, only message needs to be localized (the $parameter$ does not need to be localized since it will be replaced).

  "pomodoro_count_many": {
    "message": "$count$ Pomodoros",
    "description": "Label for many Pomodoros. Shown on the expiration page.",
    "placeholders": {
      "count": {
        "content": "$1",
        "example": "10"
      }
    }
  }

I'm still working through internationalizing everything (some parts of the UI are tricky), but I'm hoping to have it done by today. Adding the Hacktoberfest tag is a great idea. I'll add it once everything is ready.

@ofou
Copy link
Contributor

ofou commented Oct 17, 2017

I finished the Spanish translation, it is my first contribution, so I don't know if I've done it correctly. Any advice will be appreciated.

@ofou
Copy link
Contributor

ofou commented Oct 18, 2017

Hey, I'd wanted to say something about the Chrome locale table, because I'm doing the es_419 #83 (Latin America and Caribbean) translation but it's kind of the same for es (Spain). I lived in Spain for five years and they use the same expresions. I really don't know how Chrome locale table works for Spaniards, do they get the same as es_419?

@schmich
Copy link
Owner Author

schmich commented Oct 18, 2017

I really don't know how Chrome locale table works for Spaniards, do they get the same as es_419?

Right now, they wouldn't. en is the default, es is more specific, and es_419 is even more specific. Chrome resolves locales from most-to-least specific, so if someone ran Chrome as es-ES (Spanish/Spain), Chrome would look for the es locale, see that it was missing, and then fall back to the en locale.

I'm not familiar with the differences between Spanish and Spanish (Latin America and Caribbean), but from what you're saying, it sounds a lot like the difference between US English (en-US) and British English (en-GB): some things are spelled differently, some things are named slightly differently, but mostly they're the same language and either can be understood by a native English speaker.

If that's the case, I think we should just rename es_419 to es to cover all of Spanish. If you want to update it and send a pull request, that would be great.

@schmich
Copy link
Owner Author

schmich commented Oct 18, 2017

@joselcvarela @Peel40 Internationalization is complete (minus any small strings I might've missed), so the extension is ready for full translation. You should update/recreate your forks with the latest source before translating.

As features are added, I might add more English strings. To keep the localizations in sync, I created a Ruby script to sync the en locale to any other locale. The new messages are marked with FIXME in the destination locale. (If you have Ruby installed, you can run make sync-locale from the source root to do the sync yourself).

@Peel40 I went ahead and updated es_419/messages.json with that sync script. The new messages are marked FIXME.

@alexkolson
Copy link
Contributor

alexkolson commented Oct 18, 2017

This extension rocks! I would love to add German localization.

@schmich
Copy link
Owner Author

schmich commented Oct 18, 2017

@alexkolson Fantastisch! I took a few years of German in school and I have some German family roots, but I'd fail miserably if I tried.

I added you to the list up top. The Translation Guide should be all you need, but let me know if anything is unclear.

@LambisElef
Copy link
Contributor

Working on Greek translation!

@wkillerud
Copy link

I can translate to Norwegian

@samcarecho
Copy link

I can translate to pt-BR

@MAHRahat
Copy link
Contributor

Bengali translation done!

@haveneersrobin
Copy link
Contributor

Fixed some Dutch spelling mistakes ;)
#109

@Kietzmann
Copy link

I'll work on Ukrainian

@pooriamo
Copy link
Contributor

pooriamo commented Jun 9, 2019

Hey, I submitted the Persian translation but I cannot see it. Why?

@schmich schmich closed this as completed Jun 9, 2019
@schmich schmich reopened this Jun 9, 2019
@schmich
Copy link
Owner Author

schmich commented Jun 9, 2019

@pooriamo It looks like you've created your own fork with your changes successfully. Now, all you need to do is submit a pull request.

Once you do so, I will be able to accept and integrate your changes into the main repository here. Thanks for your contribution! Let me know if you need more assistance.

@pooriamo
Copy link
Contributor

pooriamo commented Jun 9, 2019

@schmich I already did it as your instructions, I tried again and now it says: schmich:master and pooriamo:master are identical.

@schmich
Copy link
Owner Author

schmich commented Jun 9, 2019

@pooriamo Your changes are in your own fork, and also in a branch off of the master branch. In this case, your changes are in your patch-1 branch.

When creating the pull request, you'll want to compare schmich:master with pooriamo:patch-1.

Branch selection should be near the top when creating a PR. See step 4 in creating a pull request.

@pooriamo
Copy link
Contributor

pooriamo commented Jun 9, 2019

@schmich Oh I'm sorry dear. Done!

@schmich schmich added the hacktoberfest Digital Ocean Hacktoberfest label Sep 24, 2019
@Darkpingouin Darkpingouin mentioned this issue Sep 26, 2019
@rachelnml
Copy link
Contributor

Hello @schmich, just added the Malay language to Marinara! Submitted 2 PRs (one in messages.JSON & one in the Contributors.md). Hope you will approve it as one of Marinara's extensions :')

@schmich schmich removed the hacktoberfest Digital Ocean Hacktoberfest label Dec 27, 2020
@zebrayon
Copy link
Contributor

Hello, nice to meet you
After using the Marinara tool in Japan for a while, I found out that some Japanese is not included.
Are you sure you want to add some translations?

はじめまして、こんにちは
日本でMarinaraツールをしばらく使っていて、部分的に日本語が入っていないことを知りました。
いくつか翻訳を追加してもよろしいでしょうか?

@schmich schmich added the hacktoberfest Digital Ocean Hacktoberfest label Sep 22, 2021
@mantasio
Copy link
Contributor

Hey @schmich, I updated missing translation strings for Lithuanian language. Could you please review my PR (#411)?

@Ln2be
Copy link

Ln2be commented Apr 7, 2022

Hello. I want to thank you so much for this useful and simple tool that I am using for 4 years now. I am an Arabic speaker and I am more than happy to help translate this app to Arabic. Thank you again for this great work.

@AgusCasarone
Copy link

Hi! Are you still interested in a Hindi translation?

@schmich
Copy link
Owner Author

schmich commented Jul 3, 2022

Hi! Are you still interested in a Hindi translation?

@AgusCasarone For sure! Translations for any of the missing languages are most welcomed.

@AgusCasarone
Copy link

That's great! Can I start with it next week?

@schmich
Copy link
Owner Author

schmich commented Jul 13, 2022

That's great! Can I start with it next week?

@AgusCasarone Sure, take the time you need. I appreciate the effort.

@RishabhK200
Copy link
Contributor

Hi, Is this issue still open? I can help with hindi, kannada and marathi language.

@schmich
Copy link
Owner Author

schmich commented Mar 20, 2023

Hi, Is this issue still open? I can help with hindi, kannada and marathi language.

Hi @RishabhK200 yes, this issue is still open and contributions are welcomed and appreciated!

@RishabhK200
Copy link
Contributor

Great! Will start working from today onwards

@karlo220180
Copy link

karlo220180 commented Apr 20, 2024

I noticed You need Croatian ? I can do it . Let me know if it is still needed please. @schmich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Digital Ocean Hacktoberfest help wanted
Projects
None yet
Development

No branches or pull requests