Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Sphinx Documentation #242

Closed
camilamaia opened this issue Jul 26, 2020 · 13 comments
Closed

Publish Sphinx Documentation #242

camilamaia opened this issue Jul 26, 2020 · 13 comments
Assignees
Labels
Documentation Improvements or additions to documentation

Comments

@camilamaia
Copy link
Member

Publish Sphinx Documentation

The #230 implemented the auto-generated code documentation using sphinx.

We can run it locally by running

$ cd documentation
$ make html

And we can access it opening the file scanapi/documentation/build/html/index.html in a browser.

This is great, but it would be nice to have this documentation published somewhere else. One option would be to publish it inside our website scanapi.dev, repository: https://github.com/scanapi/website

@camilamaia camilamaia added the Documentation Improvements or additions to documentation label Jul 26, 2020
@5pence
Copy link
Contributor

5pence commented Jul 26, 2020

Yes can add this in Camila :) will assign myself

@5pence 5pence self-assigned this Jul 26, 2020
@camilamaia
Copy link
Member Author

Maybe a good reference of how to do this: https://github.com/marketplace/actions/sphinx-build

@camilamaia
Copy link
Member Author

camilamaia commented Oct 8, 2020

Hey, @5pence are you still working on this? Or should I clean the assignees up? Thank you!

@camilamaia camilamaia added the Hacktoberfest http://hacktoberfest.digitalocean.com/ label Oct 8, 2020
@camilamaia camilamaia added this to To do in Hacktoberfest 2020 via automation Oct 8, 2020
@Pradhvan Pradhvan added the Good First Issue Good for newcomers or first time contributors. label Jun 3, 2021
@camilamaia camilamaia removed Hacktoberfest http://hacktoberfest.digitalocean.com/ Good First Issue Good for newcomers or first time contributors. labels Jul 30, 2021
@camilamaia camilamaia added this to To do in Sprint via automation Jul 30, 2021
@jhermann
Copy link
Contributor

Just as a note, the more common subdir is docs.

And a nice feature to have is starting a sphinx-autobuild demon so any change in your editor triggers a rebuild and then a reload in your browser.

@jhermann
Copy link
Contributor

If you go with RTD, the relevant docs is Incoming Webhooks and Automation — Read the Docs 5.21.0 documentation and is almost effortless usually.

docs.scanapi.dev could be added as a CNAME for the RTD domain.

@Pradhvan
Copy link
Member

I agree with @jhermann let's go with Read The Docs with Furo Theme that urlib3 uses.

docs.scanapi.dev could be added as a CNAME for the RTD domain.

Yes, this would make sense.

@camilamaia
Copy link
Member Author

💯 agreed:

  • Read The Docs + Furo Theme
  • docs.scanapi.dev CNAME for the RTD domain

I can set the CNAME once we have all configured for the RTD domain.

@jhermann do you want to go ahead and do the setup of the RTD?

@Pradhvan
Copy link
Member

I can work on this too. RTD is something I have been wanting to try out. 😄

@jhermann
Copy link
Contributor

@Pradhvan we can do this together tomorrow, especially regarding using the right RTD account (yours or Camila's).

Also, I wonder what's in documentation right now – API docs only? If yes, the option to switch to my normal Sphinx setup would be feasible and has some advantages regarding many conveniences already built in.
https://github.com/Springerle/py-generic-project/tree/master/%7B%7Bcookiecutter.repo_name%7D%7D/docs

See https://confluencer.readthedocs.io/ for an example rendering.

@camilamaia
Copy link
Member Author

camilamaia commented Aug 1, 2021

@Pradhvan, @jhermann
I did the RTD setup: https://scanapi.readthedocs.io/en/latest/. The webhook is also configured. It is still not rendering as expected 🤔 many docstrings are not there. Like, hide_utils for example.

@jhermann It would be nice to have the docs of all docstrings, from all methods/classes. Public and private I guess. I love your cookiecutter and how it is rendered. +1 to use your structure.

@jhermann
Copy link
Contributor

jhermann commented Aug 1, 2021

OK, I'll work on a replacement -- things like hidden symbols should be handled, because I already have these things in conf.py. Will not be ready today, but likely in the course of next week.

@camilamaia camilamaia self-assigned this Aug 1, 2021
@camilamaia
Copy link
Member Author

@jhermann awesome! I will create a new issue for it and close this one, ok? Since this is pretty much done.

@camilamaia
Copy link
Member Author

@jhermann here is the new issue: #469

Would mind sending a comment there saying you want to work on it so I can assign it to you?

Sprint automation moved this from To do to Done Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
No open projects
Development

No branches or pull requests

4 participants