Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy Support #639

Closed
wants to merge 1 commit into from
Closed

Proxy Support #639

wants to merge 1 commit into from

Conversation

taconi
Copy link
Member

@taconi taconi commented May 28, 2023

Description

Implement new key proxies to request and endpoint nodes

Motivation behind this PR?

#215

What type of change is this?

Feature

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #215

@taconi taconi requested review from a team as code owners May 28, 2023 14:56
@taconi taconi self-assigned this May 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023 •
edited

Codecov Report

Merging #639 (f7ffd8b) into main (a9885e1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   97.95%   97.98%   +0.02%     
==========================================
  Files          24       24              
  Lines         784      795      +11     
==========================================
+ Hits          768      779      +11     
  Misses         16       16
Impacted Files Coverage Δ
scanapi/tree/endpoint_node.py 100.00% <100.00%> (ø)
scanapi/tree/request_node.py 100.00% <100.00%> (ø)
scanapi/tree/tree_keys.py 100.00% <100.00%> (ø)
scanapi/utils.py 100.00% <100.00%> (ø)

@taconi taconi added the Feature New feature or request label May 28, 2023
@taconi taconi added Hacktoberfest http://hacktoberfest.digitalocean.com/ hacktoberfest-accepted labels Oct 8, 2023
@taconi
Copy link
Member Author

taconi commented Dec 23, 2023

Hey 👋
Is there anything missing for this PR to be merged?

@taconi
Copy link
Member Author

taconi commented Mar 28, 2024

Closed due to inactivity

@taconi taconi closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@taconi taconi

Labels
Feature New feature or request Hacktoberfest http://hacktoberfest.digitalocean.com/ hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy Support
2 participants
@taconi @codecov-commenter