Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying "server_attributes" #9

Open
Stephan202 opened this issue Mar 19, 2017 · 3 comments
Open

Specifying "server_attributes" #9

Stephan202 opened this issue Mar 19, 2017 · 3 comments

Comments

@Stephan202
Copy link

When using the Scalyr Agent, in /etc/scalyr-agent-2/agent.json one can define zero or more server_attributes. After a cursory inspection of the scalyr-logback implementation it seems to me this project does not provide equivalent functionality. Did I perhaps miss this, or would it be possible to add such support? For example, the logstash-logback-encoder allows one to configure "Global Custom Fields" inside logback.xml; that's exactly the kind of thing I'm looking for.

@steve-scalyr
Copy link
Contributor

steve-scalyr commented Mar 19, 2017 via email

@Stephan202
Copy link
Author

@steve-scalyr, thanks, that works. Though it does mean duplicating the API key etc. inside the code, at a point before Logback is initialized. (The settings specified in logback.xml will basically be ignored, because second and subsequent calls to Events#init are NO-OPs.)

I'm not so familiar with the Logback internals, but I might try to contribute config-level support for this feature. Would you guys be interested? Also, for us to switch to this appender we'd need some of the functionality proposed in #6; are there plans that get that PR or something equivalent merged?

@steve-scalyr
Copy link
Contributor

steve-scalyr commented Mar 19, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants