Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AlertmanagerConfig resource instead of CSC ConfigMap #3539

Open
5 tasks
gdemonet opened this issue Sep 16, 2021 · 0 comments
Open
5 tasks

Use AlertmanagerConfig resource instead of CSC ConfigMap #3539

gdemonet opened this issue Sep 16, 2021 · 0 comments
Labels
complexity:medium Something that requires one or few days to fix kind:enhancement New feature or request topic: cluster&service configuration Anything related to cluster and service configuration persistence topic:monitoring Everything related to monitoring of services in a running cluster

Comments

@gdemonet
Copy link
Contributor

gdemonet commented Sep 16, 2021 •
edited

Component: alertmanager, csc

Why this is needed: CSC is harder to use, since it isn't reactive and requires a Salt orchestration.

What should be done:

  • Remove alertmanager.useExistingSecret and .secrets keys from the kube-prometheus-stack chart configuration, and define an appropriate .alertmanagerSpec.alertmanagerConfigSelector and .alertmanagerConfigNamespaceSelector
  • Deploy a default AlertmanagerConfig object (with the same values as today in salt/metalk8s/addons/prometheus-operator/config/alertmanager.yaml)
  • Define migration on upgrade from previous CSC to this configuration object
  • Rewrite documentation section about Alertmanager configuration

Test plan:

  • Post-merge upgrade (and downgrade?) tests pass

See prometheus-operator/prometheus-operator#3451
@gdemonet gdemonet added kind:enhancement New feature or request complexity:medium Something that requires one or few days to fix topic:monitoring Everything related to monitoring of services in a running cluster topic: cluster&service configuration Anything related to cluster and service configuration persistence labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:medium Something that requires one or few days to fix kind:enhancement New feature or request topic: cluster&service configuration Anything related to cluster and service configuration persistence topic:monitoring Everything related to monitoring of services in a running cluster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdemonet