Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted iso solution should trigger comprehensive error message when using solutions.sh #3397

Open
lavigne958 opened this issue May 26, 2021 · 2 comments

Comments

@lavigne958
Copy link

Component:

solutions

What happened:

  • load a solution
  • remove the iso file (for some reason)
  • load a new solution (different iso file content, path, name etc)
  • solutions.sh failed as it could not find the previous iso (deleted) and run isoinfo on it.

What was expected:

  • loading the second solution works

Steps to reproduce:

  • same steps as What happened

Resolution proposal (optional):

  • when checking all solutions iso file, if one does not exists, may be skip it depending on the expected result, if this iso file is not the one that we are looking for, or the one we want to load for example.
@NicolasT
Copy link
Contributor

When an ISO is listed in the configuration, it must exist. If it does not exist, it should be reinstated, or the configuration must be fixed (though not simply as-is: removing a solution ISO requires a procedure to be executed, it's not sufficient to merely remove a line from the config: the config needs to be 'applied' as well).

We should not 'skip' missing solutions files listed in the config, essentially accepting a 'broken' configuration.

However, if such broken configuration is detected, we must make sure to properly handle this, i.e., with a useful error message. That may be lacking.

@lavigne958 lavigne958 changed the title Deleting previously loaded iso make solutions.sh fail Deleted iso solution should trigger comprehensive error message when using solutions.sh May 26, 2021
@lavigne958
Copy link
Author

Renamed issue to match the exact problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants