Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre check to avoid deploying a node using the IP of an already deployed node #3392

Open
thomasdanan opened this issue May 21, 2021 · 0 comments
Labels
priority:medium Medium priority issues, should only be postponed if no other option topic:operations Operations-related issues topic:ui UI-related issues

Comments

@thomasdanan
Copy link
Contributor

Component:

'salt', 'ui'

Why this is needed:

The administrator may (by mistake) create a Nde specification using the IP of an already deployed node. When deploying such node, this leads to failure and may have an impact on salt-minion and key negotiation

What should be done:

When adding a node, from the UI or from the CLI, we should check that the IP to reach the node is not already referenced in the Nodes that are already part of the cluster.

Implementation proposal (strongly recommended):

Test plan:

@thomasdanan thomasdanan added topic:operations Operations-related issues topic:ui UI-related issues priority:medium Medium priority issues, should only be postponed if no other option labels May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Medium priority issues, should only be postponed if no other option topic:operations Operations-related issues topic:ui UI-related issues
Projects
None yet
Development

No branches or pull requests

1 participant