Can't delete an orphan Volume

[thomasdanan]

Component:

'storage operator', 'salt'

What happened:

For some reason, if we end up with a Volume object which is orphan (i.e. linked to a nonexisting node), it is impossible to delete it. From storage operator logs, we are getting the following:

{"level":"error","ts":1619774969.0398052,"logger":"controller-runtime.controller","msg":"Reconciler error","controller":"volume-controller","request":"/titi","error":"Node \"toto\" not found","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:258\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:232\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:211\nk8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:152\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:153\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:88"}

What was expected:

If the node referenced in the Volume Object is not part of the cluster, the storage operator should accept to delete the Volume.

Steps to reproduce

Resolution proposal (optional):