Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting isolation level for DB/DBConnection #102

Open
KevinAtSesam opened this issue Oct 22, 2020 · 3 comments
Open

Support for setting isolation level for DB/DBConnection #102

KevinAtSesam opened this issue Oct 22, 2020 · 3 comments

Comments

@KevinAtSesam
Copy link

KevinAtSesam commented Oct 22, 2020

Would it be interesting to implement a special pass-through parameter to set an isolation level for a transaction? Right now, it's possible to set an isolation level in scalikejdbc, but scalikejdbc-async misses this feature.

I haven't given much thought about the impact of this in an async setting, so please tell me if there are any unforeseen issues with such an addition.

Background details

@seratch
Copy link
Member

seratch commented Oct 22, 2020

Hello, I think the feasibility to add the feature relies on the underlying library's support - https://github.com/jasync-sql/jasync-sql

I haven't checked yet but if the library provides a unified way to set an isolation level (probably no?), it should be relatively easy. If not, I think handling the differences among RDBMSs in this library is not a great idea.

@KevinAtSesam
Copy link
Author

I already looked a bit into that a bit and right now, it looks like jasync-sql has nothing for it. It does pass the parameter on, but in no way does it facilitate anything:

Connection.kt#L20

You think it would be better to ask jasync-sql for support, and then come back here when they have something for it?

@seratch
Copy link
Member

seratch commented Oct 22, 2020

Yeah, once they support it, I'm happy to add the feature to this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants