New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_valid_proof() in verifier.py #12

Open

scaffino opened this issue Oct 15, 2024 · 1 comment

Assignees

Owner

scaffino commented Oct 15, 2024

if tx_info['error'] is None: --> check that the key error exists. Use: if 'error' not in tx_info or if tx_info is none. Also check that the result key is there (needed a few lines below)
if 'confirmations' in tx_info['result'] --> use try-except, because this if might fail (not sure about this, it might be fine as is)
the break at the end should not break unless the proof is valid. Check behaviour by using regression test

scaffino self-assigned this

Owner Author

scaffino commented Jan 10, 2025

1 and 2 should be done, but need to write test to verify behavior under different cases.

Should add a break in this function in case there is not valid proof ever?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment