Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcast_entropy function in verifier.py #11

Open
scaffino opened this issue Oct 15, 2024 · 1 comment
Open

Fix broadcast_entropy function in verifier.py #11

scaffino opened this issue Oct 15, 2024 · 1 comment
Assignees

Comments

@scaffino
Copy link
Owner

scaffino commented Oct 15, 2024

  1. in the input parameters of the function, entropy_tx is a Transaction object and not a string. Use Transaction
  2. if dry run, return test_txid at the beginning - then the more complex logic. This optimizes taking away the general stuff at the beginning and reading the more complex logic only if needed
  3. broadcast the entropy tx to every node (for loop), and check that incoming data (i.e., the transaction id) is valid. One way is to check it against the locally computed txid
  4. assert txid is not None, "Entropy not posted" --> this line now fails. Use error handling
@scaffino scaffino self-assigned this Oct 15, 2024
@scaffino
Copy link
Owner Author

Done, but needs testing as soon as the testnet node is synched up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant