Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore replacing Nat::from_float with a ctor that takes double #151

Open
saxbophone opened this issue Mar 5, 2023 · 0 comments
Open

Explore replacing Nat::from_float with a ctor that takes double #151

saxbophone opened this issue Mar 5, 2023 · 0 comments
Labels
bug Something isn't working cleanup Tidying up, refactor and minor API changes question Further information is requested

Comments

@saxbophone
Copy link
Owner

Need to regression test this along with uintmax_t ctor to make sure neither tread on eachother's toes.

Currently, trying to construct Nat from double directly will bind to uintmax_t ctor. That's fine, but we don't want to inverse to happen (casting uintmax_t to double will lose precision!) so we should test both. In an ideal world, we'd have both as separate ctors.

@saxbophone saxbophone added bug Something isn't working question Further information is requested cleanup Tidying up, refactor and minor API changes labels Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup Tidying up, refactor and minor API changes question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant