Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of divmod helper method get_max_shift() #108

Open
saxbophone opened this issue May 28, 2022 · 0 comments
Open

Improve efficiency of divmod helper method get_max_shift() #108

saxbophone opened this issue May 28, 2022 · 0 comments
Milestone

Comments

@saxbophone
Copy link
Owner

This loop was introduced into this method in #107 to fix a bug, but constitutes a potential performance bottleneck due to the repeated multiplication in the loop predicate:

// drag back down wiggle_room while shifted rhs > lhs
while (rhs * shift > lhs) {
shift._digits.pop_back();
}

@saxbophone saxbophone modified the milestones: v0.6, v0.7 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant