Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divmod bug: failing test case on this large calculation #104

Closed
saxbophone opened this issue May 28, 2022 · 1 comment · Fixed by #107
Closed

Divmod bug: failing test case on this large calculation #104

saxbophone opened this issue May 28, 2022 · 1 comment · Fixed by #107
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@saxbophone
Copy link
Owner

saxbophone commented May 28, 2022

This test case appears to hang infinitely within Nat::divmod():

using namespace com::saxbophone::arby::literals;

TEST_CASE("Failing division", "[divmod]") {
    auto [quotient, remainder] = arby::Nat::divmod(81238891391892371893_nat, 10000000000_nat);

    CHECK(quotient == 8123889139_nat);
    CHECK(remainder == 1892371893_nat);
}

See the attached commit a5769ce as a starting point for debugging this

@saxbophone saxbophone added bug Something isn't working help wanted Extra attention is needed labels May 28, 2022
@saxbophone saxbophone modified the milestone: v0.5 May 28, 2022
@saxbophone saxbophone pinned this issue May 28, 2022
@saxbophone
Copy link
Owner Author

Related to #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant