New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration from httpi to faraday #992
Comments
I took a look at this recently and it seems to require some larger refactoring changes. Basically, the way the builder pattern is applied needs to change a bit, because faraday distinguishes between "requests" and "connections" much more strongly due to concepts like http keepalive |
@pcai fingers crossed! Do you know approximately when the next version will be released? |
Sorry no eta at the moment, I am still poking at this occasionally and there seem to be a bunch of decisions around larger/cleaner refactoring vs minimizing changes. Will update when i make more progress |
any update on this? |
Feature request
httpi is now deprecated in favor of https://github.com/lostisland/faraday, so we should plan a migration to it for savon
Motivation for this feature:
httpi is no longer actively maintained, and continuing to do so would duplicate a lot of existing work already done in the ruby ecosystem.
in addition, there are many missing features in httpi that would require fairly large rewrites (for example -- keepalive support, threadsafety / global state issues come to mind). this effort is better spent migrating savon to faraday which already supports these features.
Would this introduce a breaking change?
yes, this will likely require a major version bump as the public interface for savon, and some important behaviors, might change.
Are you willing to work on this yourself?
yes
The text was updated successfully, but these errors were encountered: