Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some bugs about persist? #14

Open
justfor-stack opened this issue Nov 14, 2019 · 1 comment
Open

some bugs about persist? #14

justfor-stack opened this issue Nov 14, 2019 · 1 comment

Comments

@justfor-stack
Copy link

RDD norm is persisted at X2P.scala:21, I think it's unnecessary persist since norm is only used once in the following codes.
P is cached at SimpleTSNE.scala:38, it should be uncached after last action on P.
@Icysandwich
Copy link

Also, data at MNIST:40, p_betas at X2P.scala:34 can be cached.
dataset at MNIST.scala:25 should be uncached after line 45, since it is not used any more.
These change can improve performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Icysandwich @justfor-stack