Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we try to init tls connection against plain http the tls error is not recognized and 500 error is returned #634

Open
mmatczuk opened this issue Jan 5, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@mmatczuk
Copy link
Contributor

mmatczuk commented Jan 5, 2024

The error handling code should handle that

handleTLSRecordHeader,

For some reason (maybe due to lack of record) when connecting to plain http server with tls the tls error is not recognized.

HTTP/1.1 500 Internal Server Error
Content-Length: 99
Content-Type: text/plain; charset=utf-8
X-Forwarder-Error: sauce_connect tls: first record does not look like a TLS handshake

sauce_connect encountered an unexpected error
tls: first record does not look like a TLS handshake
@mmatczuk mmatczuk added the bug Something isn't working label Jan 5, 2024
@mmatczuk mmatczuk added this to the v1.2 milestone Jan 5, 2024
@mmatczuk mmatczuk modified the milestones: v1.2, v1.3 Feb 2, 2024
@Choraden Choraden modified the milestones: v1.3, v1.4 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants