-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirementslib fails to resolve dependency with relative path and working directory mismatch #306
Comments
@PythonCoderAS I am wondering if this change fixes the issue you have been describing or if you are describing something different: https://github.com/sarugaku/requirementslib/pull/319/files |
@matteius I tried the patch but it did not work. Here is the commands I followed: virtualenv venv
source venv/bin/activate
pip install pipenv
cd venv/lib/python3.10/site-packages/pipenv/vendor/requirementslib
patch -p1 <<< `curl -s https://github.com/sarugaku/requirementslib/commit/c1678de7661f2a6fe043e100849ca056edd941d6.diff | sed "s/src\/requirementslib\/models/models/g"`
cd "$OLDPWD"
deactivate
source venv/bin/activate # Recognize new pipenv in PATH
pipenv install
git clone https://github.com/sphinx-doc/sphinx.git
cd sphinx
pipenv install . # Errors here |
Thanks for this example @PythonCoderAS -- and if you go up a directory and do it with |
As discussed in pypa/pipenv#4900, Requirementslib has an issue when the given relative path and the working directory are different. For example, if the working directory is changed to something other than where the python script is executed, but the relative path is relative to where the script was executed, Requirementslib will fail resolving the requirement.
While it might make sense as to why it's impossible to do so, I wish that the error message was worded clearer and not so crypticly.
The text was updated successfully, but these errors were encountered: