Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird and truncated error message in AddProjectsToSessionWizard #1093

Open
srossbach opened this issue Oct 30, 2020 · 3 comments · Fixed by #1098
Open

Weird and truncated error message in AddProjectsToSessionWizard #1093

srossbach opened this issue Oct 30, 2020 · 3 comments · Fixed by #1098
Assignees
@tobous
Labels
Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Aspect: GUI Issues specific to the Saros GUI Type: Bug Issue that describes an unintended behavior of Saros

Comments

@srossbach
Copy link
Contributor

When selecting Create new Directory and that directory/project already exists the displayed error message is

  1. Truncated and only displayed if you either wait for the tooltip or "scroll" down.
  2. Contains letters that are not even part of the directory that should be created.

See attached image.

wizard_misleading_error_message
@srossbach srossbach added Type: Bug Issue that describes an unintended behavior of Saros Aspect: GUI Issues specific to the Saros GUI Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) labels Oct 30, 2020
@tobous
Copy link
Member

tobous commented Nov 9, 2020

The first issue is easily solvable. I directly used the toString of the IContainer, which includes the type of the resource as part of the path. Instead using getFullPath.toOSString() fixes the issue.

But I am not sure what to do about the size issue. I could shorten the message (which would be kind of hard as I would like to still provide all the necessary information), but this would not really resolve the issue. The issue will still occur with longer paths. I am not sure how to avoid this.

tobous added a commit that referenced this issue Nov 9, 2020
@tobous
[FIX][E] #1093 Correctly display path of existing resource for error
c0c5367 
Adjusts the error message displayed in cases where the user chooses the
option to create a new directory as part of the resource negotiation
using values pointing to an already existing directory. The message used
the 'toString()' of the IContainer object which included a resource type
designation at the start of the path. To avoid confusion, the
OS-specific path of the resource is used instead.

Resolves #1093.
@tobous tobous mentioned this issue Nov 9, 2020
Merged
tobous added a commit that referenced this issue Nov 10, 2020
@tobous
[FIX][E] #1093 Correctly display path of existing resource for error
d788960 
Adjusts the error message displayed in cases where the user chooses the
option to create a new directory as part of the resource negotiation
using values pointing to an already existing directory. The message used
the 'toString()' of the IContainer object which included a resource type
designation at the start of the path. To avoid confusion, the
OS-specific path of the resource is used instead.

Resolves #1093.
@tobous
Copy link
Member

tobous commented Nov 10, 2020

My bad for prematurely closing this with the merged commit.

@srossbach What are your opinions on the remaining issues with the overlong error message?

@tobous tobous reopened this Nov 10, 2020
@srossbach
Copy link
Contributor Author

I have not found anything regarding the Wizard API that let you give the possibility to specify any hints regarding the sizing of the affected wizard part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobous tobous

Labels
Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Aspect: GUI Issues specific to the Saros GUI Type: Bug Issue that describes an unintended behavior of Saros
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issues with the paths used in the context of the local Saros instance saros-project/saros
2 participants
@tobous @srossbach