Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete workaround in ContainerContext #1060

Open
m273d15 opened this issue Jul 8, 2020 · 1 comment
Open

Remove obsolete workaround in ContainerContext #1060

m273d15 opened this issue Jul 8, 2020 · 1 comment
Labels
Area: Core Issue affecting the Saros Core good first issue Good issue to start contributing

Comments

@m273d15
Copy link
Contributor

m273d15 commented Jul 8, 2020 •
edited
Loading

The ContainerContext class contains a workaround to bypass the JDK bug JDK-4787931.
This bug should be fixed in JDKs > 7. We require at least a JDK 8.
Therefore we should be able to remove this workaround.
@m273d15 m273d15 added good first issue Good issue to start contributing Area: Core Issue affecting the Saros Core labels Jul 8, 2020
@srossbach
Copy link
Contributor

I guess the fixed logic could then be moved to the lifecycle as initializing the account store in the context is not really required for a functional operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Core Issue affecting the Saros Core good first issue Good issue to start contributing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m273d15 @srossbach