Skip to content

Commit 72d8810

Browse files
committed
Fix unit test, little refactor
1 parent 7195184 commit 72d8810

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

_test/tests/inc/changelog_getrelativerevision.test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ function test_requestrev_checkcache() {
115115
$dir = 1;
116116
$revexpected = 1362525899;
117117
$infoexpected = ChangeLog::parseLogLine($this->logline);
118+
$infoexpected['mode'] = 'page';
118119

119120
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 8192);
120121
$revfound = $pagelog->getRelativeRevision($rev, $dir);

_test/tests/inc/changelog_getrevisioninfo.test.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ function test_changemetadatanotexists() {
4343
function test_requestrev() {
4444
$rev = 1362525899;
4545
$infoexpected = ChangeLog::parseLogLine($this->logline);
46+
$infoexpected['mode'] = 'page';
4647

4748
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 8192);
4849
$info = $pagelog->getRevisionInfo($rev);
@@ -58,6 +59,7 @@ function test_requestrev() {
5859
function test_requestrev_chuncked() {
5960
$rev = 1362525899;
6061
$infoexpected = ChangeLog::parseLogLine($this->logline);
62+
$infoexpected['mode'] = 'page';
6163

6264
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 512);
6365
$info = $pagelog->getRevisionInfo($rev);
@@ -70,6 +72,7 @@ function test_requestrev_chuncked() {
7072
function test_requestrev_chunckedsmallerthanlinelength() {
7173
$rev = 1362525899;
7274
$infoexpected = ChangeLog::parseLogLine($this->logline);
75+
$infoexpected['mode'] = 'page';
7376

7477
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 20);
7578
$info = $pagelog->getRevisionInfo($rev);
@@ -82,6 +85,7 @@ function test_requestrev_chunckedsmallerthanlinelength() {
8285
function test_requestrecentestlogline() {
8386
$rev = 1374261194;
8487
$infoexpected = ChangeLog::parseLogLine($this->firstlogline);
88+
$infoexpected['mode'] = 'page';
8589

8690
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 8192);
8791
$info = $pagelog->getRevisionInfo($rev);
@@ -97,6 +101,7 @@ function test_requestrecentestlogline() {
97101
function test_requestrecentestlogline_chuncked() {
98102
$rev = 1374261194;
99103
$infoexpected = ChangeLog::parseLogLine($this->firstlogline);
104+
$infoexpected['mode'] = 'page';
100105

101106
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 512);
102107
$info = $pagelog->getRevisionInfo($rev);
@@ -111,7 +116,7 @@ function test_negativerev() {
111116

112117
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 8192);
113118
$info = $pagelog->getRevisionInfo($rev);
114-
$this->assertEquals(false, $info);
119+
$this->assertFalse($info);
115120
}
116121

117122
/**
@@ -122,7 +127,7 @@ function test_notexistingrev() {
122127

123128
$pagelog = new PageChangeLog($this->pageid, $chunk_size = 8192);
124129
$info = $pagelog->getRevisionInfo($rev);
125-
$this->assertEquals(false, $info);
130+
$this->assertFalse($info);
126131
}
127132

128133
/**
@@ -131,6 +136,7 @@ function test_notexistingrev() {
131136
function test_chuncksizetrue() {
132137
$rev = 1362525899;
133138
$infoexpected = ChangeLog::parseLogLine($this->logline);
139+
$infoexpected['mode'] = 'page';
134140

135141
$pagelog = new PageChangeLog($this->pageid, true);
136142
$info = $pagelog->getRevisionInfo($rev);

0 commit comments

Comments
 (0)